From: Jason Gunthorpe <jgg@nvidia.com>
To: Wei Wang <wei.w.wang@hotmail.com>
Cc: alex@shazbot.org, suravee.suthikulpanit@amd.com,
thomas.lendacky@amd.com, joro@8bytes.org, kevin.tian@intel.com,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH v2 1/2] iommu/amd: Add IOMMU_PROT_IE flag for memory encryption
Date: Thu, 6 Nov 2025 21:02:18 -0400 [thread overview]
Message-ID: <20251107010218.GC1708009@nvidia.com> (raw)
In-Reply-To: <SI2PR01MB439351F0B7E54513710BBD3DDCC7A@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>
On Mon, Nov 03, 2025 at 10:00:33PM +0800, Wei Wang wrote:
> Introduce the IOMMU_PROT_IE flag to allow callers of iommu_v1_map_pages()
> to explicitly request memory encryption for specific mappings.
>
> With SME enabled, the C-bit (encryption bit) in IOMMU page table entries
> is now set only when IOMMU_PROT_IE is specified. This provides
> fine-grained control over which IOVAs are encrypted through the IOMMU
> page tables.
>
> Current PCIe devices and switches do not interpret the C-bit, so applying
> it to MMIO mappings would break PCIe peer‑to‑peer communication. Update
> the implementation to restrict C-bit usage to non‑MMIO backed IOVAs.
>
> Fixes: 2543a786aa25 ("iommu/amd: Allow the AMD IOMMU to work with memory encryption")
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Wei Wang <wei.w.wang@hotmail.com>
> ---
> drivers/iommu/amd/amd_iommu_types.h | 3 ++-
> drivers/iommu/amd/io_pgtable.c | 7 +++++--
> drivers/iommu/amd/iommu.c | 2 ++
> 3 files changed, 9 insertions(+), 3 deletions(-)
Since Joerg took the iommupt patches this will need to be rebased on
his tree, I think it will be simpler..
Jason
next prev parent reply other threads:[~2025-11-07 1:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 14:00 [PATCH v2 0/2] iommu/amd: Avoid setting C-bit for MMIO addresses Wei Wang
2025-11-03 14:00 ` [PATCH v2 1/2] iommu/amd: Add IOMMU_PROT_IE flag for memory encryption Wei Wang
2025-11-07 1:02 ` Jason Gunthorpe [this message]
2025-11-07 2:39 ` Wei Wang
2025-11-10 9:55 ` Vasant Hegde
2025-11-11 1:18 ` Wei Wang
2025-11-11 4:44 ` Vasant Hegde
2025-11-03 14:00 ` [PATCH v2 2/2] vfio/type1: Set IOMMU_MMIO in dma->prot for MMIO-backed addresses Wei Wang
2025-11-07 1:03 ` Jason Gunthorpe
2025-11-07 2:38 ` Wei Wang
2025-11-07 14:16 ` Jason Gunthorpe
[not found] ` <SI2PR01MB4393E04163E5AC9FD45D56EFDCC3A@SI2PR01MB4393.apcprd01.prod.exchangelabs.com>
2025-11-07 15:57 ` Jason Gunthorpe
2025-11-07 16:19 ` Wei Wang
2025-11-07 16:36 ` Jason Gunthorpe
2025-11-07 17:56 ` Tom Lendacky
2025-11-07 18:32 ` Jason Gunthorpe
2025-11-07 19:59 ` Tom Lendacky
2025-11-10 6:28 ` Wei Wang
2025-11-10 9:55 ` Vasant Hegde
2025-11-18 14:36 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107010218.GC1708009@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex@shazbot.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=wei.w.wang@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.