From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Potapenko <glider@google.com>
Cc: Aleksei Nikiforov <aleksei.nikiforov@linux.ibm.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Juergen Christ <jchrist@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH 2/2] s390/fpu: Fix kmsan in fpu_vstl function
Date: Fri, 7 Nov 2025 11:49:26 +0100 [thread overview]
Message-ID: <20251107104926.17578C07-hca@linux.ibm.com> (raw)
In-Reply-To: <CAG_fn=WufanV2DAVusDvGviWqc6woNja-H6WAL5LNgAzeo_uKg@mail.gmail.com>
On Fri, Nov 07, 2025 at 11:26:50AM +0100, Alexander Potapenko wrote:
> On Thu, Nov 6, 2025 at 5:09 PM Aleksei Nikiforov
> <aleksei.nikiforov@linux.ibm.com> wrote:
> > @@ -409,6 +410,7 @@ static __always_inline void fpu_vstl(u8 v1, u32 index, const void *vxr)
> > : [vxr] "=R" (*(u8 *)vxr)
> > : [index] "d" (index), [v1] "I" (v1)
> > : "memory", "1");
> > + instrument_write_after(vxr, size);
> > }
>
> Wouldn't it be easier to just call kmsan_unpoison_memory() here directly?
I guess that's your call. Looks like we have already a couple of
kmsan_unpoison_memory() behind inline assemblies.
So I guess we should either continue using kmsan_unpoison_memory()
directly, or convert all of them to such a new helper. Both works of
course. What do you prefer?
next prev parent reply other threads:[~2025-11-07 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:08 [PATCH 0/2] s390/fpu: Fix kmsan false-positive report Aleksei Nikiforov
2025-11-06 16:08 ` [PATCH 1/2] instrumented.h: Add function instrument_write_after Aleksei Nikiforov
2025-11-06 16:08 ` [PATCH 2/2] s390/fpu: Fix kmsan in fpu_vstl function Aleksei Nikiforov
2025-11-07 10:26 ` Alexander Potapenko
2025-11-07 10:49 ` Heiko Carstens [this message]
2025-11-07 13:32 ` Alexander Potapenko
2025-11-07 15:33 ` Aleksei Nikiforov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107104926.17578C07-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aleksei.nikiforov@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=jchrist@linux.ibm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.