Re: [RFC PATCH 1/2] gcc-plugins: add cleanup_plugin for uninitialized cleanup detection

[kernel test robot <lkp@intel.com>]

Hi Li,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on kees/for-next/hardening]
[also build test ERROR on kees/for-next/pstore kees/for-next/kspp linus/master v6.18-rc4 next-20251107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Chen/gcc-plugins-cleanup_plugin-detect-NULL-init/20251105-174800
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening
patch link:    https://lore.kernel.org/r/20251105084733.3598704-6-me%40linux.beauty
patch subject: [RFC PATCH 1/2] gcc-plugins: add cleanup_plugin for uninitialized cleanup detection
config: s390-randconfig-001-20251107 (https://download.01.org/0day-ci/archive/20251107/202511071503.SwmZ6V4M-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251107/202511071503.SwmZ6V4M-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511071503.SwmZ6V4M-lkp@intel.com/

All errors (new ones prefixed by >>):

   scripts/gcc-plugins/cleanup_plugin.c: In function 'void warn_if_uninitialized(tree)':
>> scripts/gcc-plugins/cleanup_plugin.c:70:45: error: 'struct diagnostic_context' has no member named 'warning_as_error_requested_p'; did you mean 'warning_as_error_requested'?
      70 |         saved_warning_as_error = global_dc->warning_as_error_requested_p();
         |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                             warning_as_error_requested
>> scripts/gcc-plugins/cleanup_plugin.c:71:20: error: 'struct diagnostic_context' has no member named 'set_warning_as_error_requested'; did you mean 'warning_as_error_requested'?
      71 |         global_dc->set_warning_as_error_requested(false);
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                    warning_as_error_requested
   scripts/gcc-plugins/cleanup_plugin.c:77:20: error: 'struct diagnostic_context' has no member named 'set_warning_as_error_requested'; did you mean 'warning_as_error_requested'?
      77 |         global_dc->set_warning_as_error_requested(saved_warning_as_error);
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                    warning_as_error_requested
   make[4]: *** [scripts/gcc-plugins/Makefile:54: scripts/gcc-plugins/cleanup_plugin.so] Error 1 shuffle=3970265060
   make[4]: Target 'scripts/gcc-plugins/' not remade because of errors.
   make[3]: *** [scripts/Makefile.build:556: scripts/gcc-plugins] Error 2 shuffle=3970265060
   make[3]: Target 'scripts/' not remade because of errors.
   make[2]: *** [Makefile:1263: scripts] Error 2 shuffle=3970265060
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:248: __sub-make] Error 2 shuffle=3970265060
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:248: __sub-make] Error 2 shuffle=3970265060
   make: Target 'prepare' not remade because of errors.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for OF_GPIO
   Depends on [n]: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n]
   Selected by [m]:
   - REGULATOR_RT5133 [=m] && REGULATOR [=y] && I2C [=m] && GPIOLIB [=y] && OF [=y]


vim +70 scripts/gcc-plugins/cleanup_plugin.c

    56	
    57	static void warn_if_uninitialized(tree var)
    58	{
    59		location_t loc;
    60		bool saved_warning_as_error;
    61	
    62		if (has_declaration_initializer(var))
    63			return;
    64	
    65		loc = DECL_SOURCE_LOCATION(var);
    66		if (loc == UNKNOWN_LOCATION)
    67			return;
    68	
    69		/* Temporarily disable treating warnings as errors for this specific warning */
  > 70		saved_warning_as_error = global_dc->warning_as_error_requested_p();
  > 71		global_dc->set_warning_as_error_requested(false);
    72		warning_at(
    73			loc, 0,
    74			"%qD declared with cleanup attribute is not initialized at declaration",
    75			var);
    76		/* Restore the original setting */
    77		global_dc->set_warning_as_error_requested(saved_warning_as_error);
    78	}
    79	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki