Re: [PATCH 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930

[Andreas Kemnade <andreas@kemnade.info>]

On Sat, 8 Nov 2025 13:17:31 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Fri, Nov 07, 2025 at 09:06:45PM +0100, Andreas Kemnade wrote:
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - const: fiti,fp9931
> > +
> > +      - items:
> > +          - const: fiti,jd9930
> > +          - const: fiti,fp9931
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#thermal-sensor-cells':  
> 
> Why is this a thermal zone sensor? Aren't you mixing temperature
> reading with soc? For temperature reading you can use hwmon, for
> example.
> 
well, I just took the SY7636A as reference. Is there any document describing
the terme "thermal zone sensor". I would define a thermal zone as an area
with things influencing each other thermically. These things are
sensors, heat sources and sinks. Well, the panel typically does not produce
much heat.
But I do not insist on having that property here. As far as I understand,
the hwmon uses this property as an indication to also create a thermal zone
sensor.

> > +    const: 0
> > +
> > +  enable-gpios:
> > +    maxItems: 1
> > +
> > +  pg-gpios:
> > +    maxItems: 1
> > +
> > +  ts-en-gpios:  
> 
> It's called EN_TS, so en-ts-gpios.
> 
ok
> 
> > +    maxItems: 1
> > +
> > +  xon-gpios:  
> 
> That's powerdown-gpios, see gpio-consumer-common.
> 
looking a bit around: powerdown-gpios e.g. in the MCP4801
describe an *input*, which should be connected to an output of the SoC. 
Looking at the datasheet, I see "XON Open Drain N-MOS On-Resistance" so it is
an *output* (same as for PG). So it is something different then the
powerdown-gpios in e.g. the MCP4801.
So it is a signal coming from the JD9930 after EN goes low in the power down
sequence.

> > +    maxItems: 1
> > +
> > +  vin-supply:
> > +    description:
> > +      Supply for the whole chip. Some vendor kernels and devicetrees
> > +      declare this as a non-existing GPIO named "pwrall".
> > +
> > +  fiti,tdly:  
> 
> No, look at datasheet. What values are there? ms.
> 
Hmm, no to what? I do not understand your comment.
So I guess a bit what might be options to discuss here:
- put raw value for the bitfield here (what is currently done).
- put the ms values here (then I would expect a suffix in the property name)
  We have the mapping 0ms - 0, 1ms - 1, 2ms - 2, 4ms - 3, so it is
  not identical.

Regards,
Andreas