From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org, jack@suse.cz,
mjguzik@gmail.com, paul@paul-moore.com, axboe@kernel.dk,
audit@vger.kernel.org, io-uring@vger.kernel.org
Subject: Re: [RFC][PATCH 10/13] get rid of audit_reusename()
Date: Mon, 10 Nov 2025 06:05:54 +0000 [thread overview]
Message-ID: <20251110060554.GK2441659@ZenIV> (raw)
In-Reply-To: <CAHk-=wjA=iXRyu1-ABST43vdT60Md9zpQDJ4Kg14V3f_2Bf+BA@mail.gmail.com>
On Sun, Nov 09, 2025 at 02:18:04PM -0800, Linus Torvalds wrote:
> On Sun, 9 Nov 2025 at 11:18, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Hmm? Comments?
>
> Oh, and while double-checking bad users, I note that ntfs3 does
>
> uni = kmem_cache_alloc(names_cachep, GFP_NOWAIT);
> ...
> kmem_cache_free(names_cachep, uni);
>
> which is all complete and utter bogosity. I have no idea why anybody
> ever thought that was acceptable. It's garbage.
So's ntfs_d_compare() right next to it - and there they *still*
hadn't bothered with non-blocking allocation while under ->d_lock and
rcu_read_lock()...
next prev parent reply other threads:[~2025-11-10 6:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-09 6:37 [RFC][PATCH 00/13] io_uring, struct filename and audit Al Viro
2025-11-09 6:37 ` [RFC][PATCH 01/13] do_faccessat(): import pathname only once Al Viro
2025-11-13 10:11 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 02/13] do_fchmodat(): " Al Viro
2025-11-13 10:12 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 03/13] do_fchownat(): " Al Viro
2025-11-13 10:13 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 04/13] do_utimes_path(): " Al Viro
2025-11-13 10:15 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 05/13] chdir(2): " Al Viro
2025-11-13 10:16 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 06/13] chroot(2): " Al Viro
2025-11-13 10:18 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 07/13] user_statfs(): " Al Viro
2025-11-13 10:18 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 08/13] do_sys_truncate(): " Al Viro
2025-11-13 10:18 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 09/13] do_readlinkat(): " Al Viro
2025-11-13 10:20 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 10/13] get rid of audit_reusename() Al Viro
2025-11-09 19:18 ` Linus Torvalds
2025-11-09 19:55 ` Mateusz Guzik
2025-11-09 20:22 ` Linus Torvalds
2025-11-09 22:18 ` Mateusz Guzik
2025-11-09 22:29 ` Linus Torvalds
2025-11-09 22:33 ` Mateusz Guzik
2025-11-09 22:39 ` Mateusz Guzik
2025-11-09 22:41 ` Linus Torvalds
2025-11-09 22:44 ` Linus Torvalds
2025-11-09 23:07 ` Linus Torvalds
2025-11-09 22:18 ` Linus Torvalds
2025-11-10 5:17 ` Al Viro
2025-11-10 16:41 ` Linus Torvalds
2025-11-10 19:58 ` Al Viro
2025-11-10 20:52 ` Linus Torvalds
2025-11-11 1:16 ` Al Viro
2025-11-12 9:26 ` Christian Brauner
2025-11-10 6:05 ` Al Viro [this message]
2025-11-10 6:36 ` Al Viro
2025-11-10 16:50 ` Linus Torvalds
2025-11-10 23:13 ` Paul Moore
2025-11-11 0:23 ` Paul Moore
2025-11-13 10:29 ` Jan Kara
2025-11-09 6:37 ` [RFC][PATCH 11/13] allow incomplete imports of filenames Al Viro
2025-11-11 0:45 ` Paul Moore
2025-11-11 14:41 ` Jens Axboe
2025-11-19 1:12 ` Al Viro
2025-11-19 1:14 ` Al Viro
2025-11-19 5:41 ` Al Viro
2025-11-09 6:37 ` [RFC][PATCH 12/13] fs: touch up predicts in putname() Al Viro
2025-11-09 6:37 ` [RFC][PATCH 13/13] struct filename ->refcnt doesn't need to be atomic Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110060554.GK2441659@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=audit@vger.kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=paul@paul-moore.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.