From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5B50CCFA13 for ; Mon, 10 Nov 2025 23:01:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7930360AE8; Mon, 10 Nov 2025 23:01:40 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uPwilAboGBgw; Mon, 10 Nov 2025 23:01:39 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org ED8BB60AEC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1762815699; bh=r1tN2gxr595XAwJ0SPkwcrUmxMxwbMA4icSMwYnrAy0=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=6UiBK/Bqx5w8I5BLckG9WaBMflt84Nw0jpuv/MCIPVyYDX8JJYDI1wA6BJrmLNS1E K56+JkgR/oQbsNb08w62zhKI5xctdQXQlJ8W5CCzVpQOoEO8l4YWW4DiSLOvwePwTa a/hEA8nE4QRSmUp8SbQQUBxaZwMuqAAb8d/tn6BM3fKVYyEyrF+vs2bkp4pqYmdB09 pnILQ0UzziyY/XquSs6ehAZCOOx8wp7gyZtnf3LlFsTAQ9f20anqw+b4t7AP9iz38I /zsQWosh1j9FI+QvjgEZe/O4bb99iL5a6or13bNGbwGI8E3fgFBiZa6m67nMRPhRb/ vVyMDt4achogQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id ED8BB60AEC; Mon, 10 Nov 2025 23:01:38 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id C8A50FA for ; Mon, 10 Nov 2025 23:01:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A941660AEC for ; Mon, 10 Nov 2025 23:01:37 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qN5fmN9Uuss3 for ; Mon, 10 Nov 2025 23:01:37 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 175EE60ADB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 175EE60ADB Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id 175EE60ADB for ; Mon, 10 Nov 2025 23:01:36 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A093C444C9; Mon, 10 Nov 2025 23:01:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FF72C113D0; Mon, 10 Nov 2025 23:01:34 +0000 (UTC) Date: Mon, 10 Nov 2025 15:01:33 -0800 From: Jakub Kicinski To: Saeed Mahameed Cc: Daniel Zahka , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Srujana Challa , Bharat Bhushan , Herbert Xu , Brett Creeley , Andrew Lunn , Michael Chan , Pavan Chebbi , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , Maxime Coquelin , Alexandre Torgue , Siddharth Vadapalli , Roger Quadros , Loic Poulain , Sergey Ryazanov , Johannes Berg , Vladimir Oltean , Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman , Vlad Dumitrescu , "Russell King (Oracle)" , Alexander Sverdlin , Lorenzo Bianconi , netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20251110150133.04a2e905@kernel.org> In-Reply-To: References: <20251107204347.4060542-1-daniel.zahka@gmail.com> <20251107204347.4060542-3-daniel.zahka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762815696; bh=pw8l6QAhWfbgalj/rdjn7/vFNJjdaYWZBrq9g5kSPg4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S8HLZtN4P9lQykfRX66OjCW5XNx3EB4nqyUYkr1K6qVFAiH/1B2WuyT6Xhr1zrk3/ ExH2jrpU7zVP87t7kjXI3Kt7IahNaP4FHi9dEbWmkOfhcNkjbdFjYkvn4BLSd1EO/T mW7RS3pOB4sk39x+S77N8ZE2JAcYlWzhiXk3H/uSO91rQ9fRt5JYiPOs+MVIHezx3p x9hl9uOQ1E29htlhgUjiKxDmue8SYA7DhtwxpT5AFCPuGOlVR6hlAxRLWDHkZVinqY BGjV1lxESgN7GVwIwfb+L72Fky5jmzzbLAUnbIGEkRxFXZVmRVflMaGWkr0kgqrKoi I+5wpEmr7hZzw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=S8HLZtN4 Subject: Re: [Intel-wired-lan] [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 7 Nov 2025 22:14:45 -0800 Saeed Mahameed wrote: > >+ err = mlx5_nv_param_read_sw_accelerate_conf(dev, mnvda, sizeof(mnvda)); > >+ if (err) { > >+ NL_SET_ERR_MSG_MOD(extack, > >+ "Failed to read sw_accelerate_conf mnvda reg"); > > Plug in the err, NL_SET_ERR_MSG_FMT_MOD(.., .., err); > other locations as well. Incorrect. extack should basically be passed to perror() IOW user space will add strerror(errno) after, anyway. Adding the errno inside the string is pointless and ugly. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00A419CD05; Mon, 10 Nov 2025 23:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762815697; cv=none; b=llwHYw98LDg1jEgohKHiOpmQatWxrCuEx10oFAHmUIFYZy52yQCk59pTB403wQABkHRBEpjow2laKD+jmI//U6+xZbzDu8HJjzG+eyW+oiLhNJmfuLGLXRsoCmEQe1f9VDiw75YmpKeFdBPpW316fi800gUlCX+X5Sz4Z1GiX/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762815697; c=relaxed/simple; bh=pw8l6QAhWfbgalj/rdjn7/vFNJjdaYWZBrq9g5kSPg4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XARdjfXo6dpk1lZ4kBTNqrmZtWjEEnyQTJPd3yH/pMFFWVD+XwdZeIPI8QOlQPIB01VcYrdpwycHsB9YoAKmYICZama8Td268l9qyaf9Smrdf20PFjrkkowwdPNmhIMimFcBd0vWO0zNm443/ErB8499Dqc9j4MBo9HWbqcSrzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S8HLZtN4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S8HLZtN4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FF72C113D0; Mon, 10 Nov 2025 23:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762815696; bh=pw8l6QAhWfbgalj/rdjn7/vFNJjdaYWZBrq9g5kSPg4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S8HLZtN4P9lQykfRX66OjCW5XNx3EB4nqyUYkr1K6qVFAiH/1B2WuyT6Xhr1zrk3/ ExH2jrpU7zVP87t7kjXI3Kt7IahNaP4FHi9dEbWmkOfhcNkjbdFjYkvn4BLSd1EO/T mW7RS3pOB4sk39x+S77N8ZE2JAcYlWzhiXk3H/uSO91rQ9fRt5JYiPOs+MVIHezx3p x9hl9uOQ1E29htlhgUjiKxDmue8SYA7DhtwxpT5AFCPuGOlVR6hlAxRLWDHkZVinqY BGjV1lxESgN7GVwIwfb+L72Fky5jmzzbLAUnbIGEkRxFXZVmRVflMaGWkr0kgqrKoi I+5wpEmr7hZzw== Date: Mon, 10 Nov 2025 15:01:33 -0800 From: Jakub Kicinski To: Saeed Mahameed Cc: Daniel Zahka , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Srujana Challa , Bharat Bhushan , Herbert Xu , Brett Creeley , Andrew Lunn , Michael Chan , Pavan Chebbi , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , Maxime Coquelin , Alexandre Torgue , Siddharth Vadapalli , Roger Quadros , Loic Poulain , Sergey Ryazanov , Johannes Berg , Vladimir Oltean , Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman , Vlad Dumitrescu , "Russell King (Oracle)" , Alexander Sverdlin , Lorenzo Bianconi , netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params Message-ID: <20251110150133.04a2e905@kernel.org> In-Reply-To: References: <20251107204347.4060542-1-daniel.zahka@gmail.com> <20251107204347.4060542-3-daniel.zahka@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 7 Nov 2025 22:14:45 -0800 Saeed Mahameed wrote: > >+ err = mlx5_nv_param_read_sw_accelerate_conf(dev, mnvda, sizeof(mnvda)); > >+ if (err) { > >+ NL_SET_ERR_MSG_MOD(extack, > >+ "Failed to read sw_accelerate_conf mnvda reg"); > > Plug in the err, NL_SET_ERR_MSG_FMT_MOD(.., .., err); > other locations as well. Incorrect. extack should basically be passed to perror() IOW user space will add strerror(errno) after, anyway. Adding the errno inside the string is pointless and ugly.