From: Jakub Kicinski <kuba@kernel.org>
To: Fan Gong <gongfan1@huawei.com>
Cc: Zhu Yikai <zhuyikai1@h-partners.com>, <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Markus Elfring <Markus.Elfring@web.de>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
ALOK TIWARI <alok.a.tiwari@oracle.com>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
luosifu <luosifu@huawei.com>, Xin Guo <guoxin09@huawei.com>,
Shen Chenyang <shenchenyang1@hisilicon.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Luo Yang <luoyang82@h-partners.com>,
Meny Yossefi <meny.yossefi@huawei.com>,
Gur Stavi <gur.stavi@huawei.com>
Subject: Re: [PATCH net-next v06 2/5] hinic3: Add PF management interfaces
Date: Mon, 10 Nov 2025 18:47:43 -0800 [thread overview]
Message-ID: <20251110184743.72f0fe8d@kernel.org> (raw)
In-Reply-To: <c344db0c471b6b1321994958727df1c005a65daa.1762581665.git.zhuyikai1@h-partners.com>
On Sat, 8 Nov 2025 14:41:37 +0800 Fan Gong wrote:
> + struct semaphore port_state_sem;
You seem to init this semaphore to 1, could you not use a mutex?
Mutexes are faster and have better debugging. If you have a reason
for a semaphore please document.
next prev parent reply other threads:[~2025-11-11 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 6:41 [PATCH net-next v06 0/5] net: hinic3: PF initialization Fan Gong
2025-11-08 6:41 ` [PATCH net-next v06 1/5] hinic3: Add PF framework Fan Gong
2025-11-08 6:41 ` [PATCH net-next v06 2/5] hinic3: Add PF management interfaces Fan Gong
2025-11-11 2:47 ` Jakub Kicinski [this message]
2025-11-08 6:41 ` [PATCH net-next v06 3/5] hinic3: Add NIC configuration ops Fan Gong
2025-11-11 2:56 ` Jakub Kicinski
2025-11-08 6:41 ` [PATCH net-next v06 4/5] hinic3: Add mac filter ops Fan Gong
2025-11-08 6:41 ` [PATCH net-next v06 5/5] hinic3: Add netdev register interfaces Fan Gong
2025-11-11 3:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110184743.72f0fe8d@kernel.org \
--to=kuba@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=luoyang82@h-partners.com \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.