From: Nathan Chancellor <nathan@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Jens Reidel <adrian@mainlining.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] mips: Use generic endianness macros instead of MIPS-specific ones
Date: Mon, 10 Nov 2025 14:08:35 -0700 [thread overview]
Message-ID: <20251110210835.GA302594@ax162> (raw)
In-Reply-To: <alpine.DEB.2.21.2511100050330.25436@angie.orcam.me.uk>
On Mon, Nov 10, 2025 at 01:34:19AM +0000, Maciej W. Rozycki wrote:
> Also please don't review changes based on assumptions, "I assume GCC
> does[...]" means that you just don't know (and it's trivial to check).
Yes, that is totally valid. I hastily reviewed this when I should have
taken the time to check but I did not have a MIPS cross compiler
available locally to test and I forgot that I can use Godbolt for that
test. I'll be more mindful of that in the future (or at least being
clear that I did not actually check but it should be verified before the
change is merged without providing a tag).
> target macros. Since our current GCC requirement is 5.1 it will be fine
Just an FYI, the minimum GCC version is 8.1 since commit 118c40b7b503
("kbuild: require gcc-8 and binutils-2.30") in 6.16.
Cheers,
Nathan
next prev parent reply other threads:[~2025-11-10 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 22:05 [PATCH] mips: Use generic endianness macros instead of MIPS-specific ones Jens Reidel
2025-11-09 23:37 ` Nathan Chancellor
2025-11-10 1:34 ` Maciej W. Rozycki
2025-11-10 21:08 ` Nathan Chancellor [this message]
2025-11-10 21:32 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110210835.GA302594@ax162 \
--to=nathan@kernel.org \
--cc=adrian@mainlining.org \
--cc=bpf@vger.kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=macro@orcam.me.uk \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.