From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3C6255F28; Tue, 11 Nov 2025 01:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762824542; cv=none; b=Mh3XxT0cVZ9wD8hihkaQh00NjhvEpk7VwiC5eIq72WksRpxl/ykul9M9xr+Kn4jmDji1fcylIfLlqXo+0Xw0zAEd3ciYcZWY36BY5zX1ZH8IUrBjKNbGChX3yU35+JPvhOSRirZrHPycZUQl3G0outr3/Zlj+gqf22rHdmZdue8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762824542; c=relaxed/simple; bh=03J0F2otaNnr9rPSGR+P3nWHFcW8CECm4DfimWhQYcY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TyVLwqj2R2Rh8Khkw3Kgd7XH0IzZVjRJLPD/42zCC8ueKTHL9jx79jNybCMON40o9ioZqSK0hEseLXdJniYor0mKm7OwX/jyphgF3DjXar2ze7aQymxTB8m80pihr9FlhTvTJM/9UPWCM9y1aZlTVbW9x5qT3+X842gZv4n/IGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0QAx49HV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0QAx49HV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E631BC4CEF5; Tue, 11 Nov 2025 01:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762824542; bh=03J0F2otaNnr9rPSGR+P3nWHFcW8CECm4DfimWhQYcY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0QAx49HVtqzAa7PeTpeCA2+279vRhz662BcUi89RJqAfYPUaOZDkad7ekvcLX3skX ec28wOYOerkAwWoOnFwFPJ213rjPq71NyAQ1NV1PUh86g4fYZH8LNx0YMTfBI3V3r6 cyt/PUdD7keaVeX57HwnN45BufmhYkCSOTn1lT8A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Palmer , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.17 520/849] eth: 8139too: Make 8139TOO_PIO depend on !NO_IOPORT_MAP Date: Tue, 11 Nov 2025 09:41:30 +0900 Message-ID: <20251111004548.995242142@linuxfoundation.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251111004536.460310036@linuxfoundation.org> References: <20251111004536.460310036@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Palmer [ Upstream commit 43adad382e1fdecabd2c4cd2bea777ef4ce4109e ] When 8139too is probing and 8139TOO_PIO=y it will call pci_iomap_range() and from there __pci_ioport_map() for the PCI IO space. If HAS_IOPORT_MAP=n and NO_GENERIC_PCI_IOPORT_MAP=n, like it is on my m68k config, __pci_ioport_map() becomes NULL, pci_iomap_range() will always fail and the driver will complain it couldn't map the PIO space and return an error. NO_IOPORT_MAP seems to cover the case where what 8139too is trying to do cannot ever work so make 8139TOO_PIO depend on being it false and avoid creating an unusable driver. Signed-off-by: Daniel Palmer Link: https://patch.msgid.link/20250907064349.3427600-1-daniel@thingy.jp Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig index fe136f61586fe..272c83bfdc6ce 100644 --- a/drivers/net/ethernet/realtek/Kconfig +++ b/drivers/net/ethernet/realtek/Kconfig @@ -58,7 +58,7 @@ config 8139TOO config 8139TOO_PIO bool "Use PIO instead of MMIO" default y - depends on 8139TOO + depends on 8139TOO && !NO_IOPORT_MAP help This instructs the driver to use programmed I/O ports (PIO) instead of PCI shared memory (MMIO). This can possibly solve some problems -- 2.51.0