From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA65E26D4DE; Tue, 11 Nov 2025 01:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825056; cv=none; b=YATvPtCHRBTpZwsAPgeTBBv5t+irOCzBemg6VmDPHnD00OiKBB39dxoXicS7FxvZHkVPfv7jvfqHGVDgtFn7dFLmu/K42rwF+PyvxX6+XPCIsTI7gyonRYNciwoEzXsEjjB5bm58vOevAt8t1H9KduDizqrM2j6ZTCUsxsQ+Bek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825056; c=relaxed/simple; bh=Cx9Dge65hJhnHJKG569+pXuaeLO0Qi+SoKWWs5vKC2o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bHuvnNoUNc5xSfHFlLvydP6jqkJL9nPkWdNiUdSru1Y8SsLkHpKc89tU5Gyhi6HAwCJluasZq+B3bVPnZnTabVXfU2xixb8JtAzCbWtpprw6N4skP+C8IgwlerjEg6uqPNL9e9qujjnEk6CRaiBPRpiezCNOp4oOuFbodCokBOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LHExqxRD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LHExqxRD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45E71C19424; Tue, 11 Nov 2025 01:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762825056; bh=Cx9Dge65hJhnHJKG569+pXuaeLO0Qi+SoKWWs5vKC2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LHExqxRD4VhYizIXkASxXFSH+FMXTD4X1d1JZmVDCzr54UcHvTUt7dAyxZx79E3Zj mXmVdbS6AZLFRJpFMhWCdmUU1cQtoTbnxJgHx0xnoZVBd1OJluz2p0BDJ6/xJetiTW CjDNOdAcx69I03xeUusY/rpbHRkrTfB5cGTnD+ho= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kuninori Morimoto , Yusuke Goda , Mark Brown , Sasha Levin Subject: [PATCH 6.17 642/849] ASoC: renesas: msiof: tidyup DMAC stop timing Date: Tue, 11 Nov 2025 09:43:32 +0900 Message-ID: <20251111004551.952204787@linuxfoundation.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251111004536.460310036@linuxfoundation.org> References: <20251111004536.460310036@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuninori Morimoto [ Upstream commit 25aa058b5c83a3c455a2a288bb3295c0b234f093 ] Current DMAC is stopped before HW stop, but it might be cause of sync error. Stop HW first. Signed-off-by: Kuninori Morimoto Tested-by: Yusuke Goda Link: https://patch.msgid.link/878qi3yuu0.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/renesas/rcar/msiof.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/renesas/rcar/msiof.c b/sound/soc/renesas/rcar/msiof.c index 3a1a6496637dd..555fdd4fb2513 100644 --- a/sound/soc/renesas/rcar/msiof.c +++ b/sound/soc/renesas/rcar/msiof.c @@ -222,9 +222,6 @@ static int msiof_hw_stop(struct snd_soc_component *component, val = SIIER_RDREQE | SIIER_RDMAE | SISTR_ERR_RX; msiof_update(priv, SIIER, val, 0); - /* Stop DMAC */ - snd_dmaengine_pcm_trigger(substream, cmd); - /* SICTR */ if (is_play) val = SICTR_TXE; @@ -232,6 +229,9 @@ static int msiof_hw_stop(struct snd_soc_component *component, val = SICTR_RXE; msiof_update_and_wait(priv, SICTR, val, 0, 0); + /* Stop DMAC */ + snd_dmaengine_pcm_trigger(substream, cmd); + /* indicate error status if exist */ if (priv->err_syc[substream->stream] || priv->err_ovf[substream->stream] || -- 2.51.0