From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F248340DB7; Tue, 11 Nov 2025 01:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825101; cv=none; b=jThNnBNjbtWTiZ+gLr48Q0O0DZ6/r6J03cEKQsr9gp1uQrG3tsLoq0DYpkVUmGxhnqUkRc60IjXNw3U7EdPIXbF7VnHL+8n2ifYmLMqQ77mmxuljmjUqDvGwG5/8ksM2saOT0L6HKbNCkvjiw7j4XSXob2kaW9fMUek/mFNYhuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762825101; c=relaxed/simple; bh=8dbYneWbsQGD2lCnUMs+nZiYduBtIabTQTWoZIY586U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Io+O04qoRixfKrXoJNEyNG9DTBk1WMK/DWwJ17L/lZwPV2EtuIsdQ/wfD69kGp1hfDEjXQdS4nGk41bfSGZ44ylb+ZT5FKkcMraIn/Zcpf8td8OdgmOm8ovq0WzOql/HhWvam3xvS7rJ+eWej1QAUw5k8T/uWkCmXvBXMwiP6JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wF7TnV2c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wF7TnV2c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22E80C4CEF5; Tue, 11 Nov 2025 01:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762825101; bh=8dbYneWbsQGD2lCnUMs+nZiYduBtIabTQTWoZIY586U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wF7TnV2cQdv2jmhn6PkEMBnzmxTa/KSESCN7571zX0KXnJ3LwSZ6VEEeJK0e+5VZ8 NW7IBRfggTadmSiAWJh+Potd71KZ0FMpSVwmgEaOQpNmdzZ8Ibam8+q2Lvgu1nTmUf PzEC6KSFU2Y1srmOl0tZTBehrR90yQhVuu6zC/RY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sean Anderson , =?UTF-8?q?Th=C3=A9o=20Lebrun?= , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.17 659/849] net: macb: avoid dealing with endianness in macb_set_hwaddr() Date: Tue, 11 Nov 2025 09:43:49 +0900 Message-ID: <20251111004552.358473578@linuxfoundation.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251111004536.460310036@linuxfoundation.org> References: <20251111004536.460310036@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Théo Lebrun [ Upstream commit 70a5ce8bc94545ba0fb47b2498bfb12de2132f4d ] bp->dev->dev_addr is of type `unsigned char *`. Casting it to a u32 pointer and dereferencing implies dealing manually with endianness, which is error-prone. Replace by calls to get_unaligned_le32|le16() helpers. This was found using sparse: ⟩ make C=2 drivers/net/ethernet/cadence/macb_main.o warning: incorrect type in assignment (different base types) expected unsigned int [usertype] bottom got restricted __le32 [usertype] warning: incorrect type in assignment (different base types) expected unsigned short [usertype] top got restricted __le16 [usertype] ... Reviewed-by: Sean Anderson Signed-off-by: Théo Lebrun Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250923-macb-fixes-v6-5-772d655cdeb6@bootlin.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/cadence/macb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index fc082a7a5a313..4af2ec705ba52 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -274,9 +274,9 @@ static void macb_set_hwaddr(struct macb *bp) u32 bottom; u16 top; - bottom = cpu_to_le32(*((u32 *)bp->dev->dev_addr)); + bottom = get_unaligned_le32(bp->dev->dev_addr); macb_or_gem_writel(bp, SA1B, bottom); - top = cpu_to_le16(*((u16 *)(bp->dev->dev_addr + 4))); + top = get_unaligned_le16(bp->dev->dev_addr + 4); macb_or_gem_writel(bp, SA1T, top); if (gem_has_ptp(bp)) { -- 2.51.0