From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A58D4359FAE for ; Tue, 11 Nov 2025 18:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762884776; cv=none; b=TLz/jNOyUkzfaYh8ixsII+T/c0NVuTdIhHzLmYor52PUf51S+P1HmnokDIY54BrQcOimJuuTRxThxxtWLwrXtS5GXvPsASnYZB57eFFuxexfLwofbTNxMGmuHdYoyjzCqpdsUZLom7vGJBmpaEZ+KQ8Wv1m2QG8NkiwJieRMgqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762884776; c=relaxed/simple; bh=Wkh0MXpt0jkH3qMK7memVYmYm/3Zw3vmTkjgkL9MuJ4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a778AVGvJN5+ciA7VjTIi/mtca4c5jxiiw4qu40BIBnzDMSmjctfD7HX9TTKcwsnygxFaC3OPE8rhQODNL2jQcE/LLrtMl8Vq00JpHCnXZt0QyjpZkpnCiM6P0boqqMfIMxF7w8S+wQP+3ceAgd2FGTDo7+F+mVWIPzKnbSBgME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MGFwW7ew; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MGFwW7ew" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762884773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kbBT0LpREuk2X1cRxrYwVwo+ggq8/d3myNs3fV/FRtA=; b=MGFwW7ewN33+FgAbnpr1Y/0N9rUoNEVlqT4TjRjPv0ElbLV+ICldYf2OwsFxTPcfCFOlXb xNwa9Il4yQ1SKJcy7qwh7nWO5zKlqTtwcbMkLZzVw2JvmK0mTmWZ0nDmFv0+7G1xJXOine cZBN2vNNDtTRUaERe/SsujkRhQJifgk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-NPOeYaAjOu-TTXVDs8HqEA-1; Tue, 11 Nov 2025 13:12:52 -0500 X-MC-Unique: NPOeYaAjOu-TTXVDs8HqEA-1 X-Mimecast-MFC-AGG-ID: NPOeYaAjOu-TTXVDs8HqEA_1762884770 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F06F18002C2; Tue, 11 Nov 2025 18:12:50 +0000 (UTC) Received: from p16v.redhat.com (unknown [10.44.32.20]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AE31E1800451; Tue, 11 Nov 2025 18:12:45 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Michal Schmidt , Petr Oros , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 0/6] dpll: zl3073x: Refactor state management Date: Tue, 11 Nov 2025 19:12:37 +0100 Message-ID: <20251111181243.4570-1-ivecera@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 This patch set is a refactoring of the zl3073x driver to clean up state management, improve modularity, and significantly reduce on-demand I/O. The driver's dpll.c implementation previously performed on-demand register reads and writes (wrapped in mailbox operations) to get or set properties like frequency, phase, and embedded-sync settings. This cluttered the DPLL logic with low-level I/O, duplicated locking, and led to inefficient bus traffic. This series addresses this by: 1. Splitting the monolithic 'core.c' into logical units ('ref.c', 'out.c', 'synth.c'). 2. Implementing a full read/write-back cache for 'zl3073x_ref' and 'zl3073x_out' structures. All state is now read once during '_state_fetch()' (and status updated periodically). DPLL get callbacks read from this cache. Set callbacks modify a copy of the state, which is then committed via a new '..._state_set()' function. These '_state_set' functions compare the new state to the cached state and write *only* the modified register values back to the hardware, all within a single mailbox sequence. The result is a much cleaner 'dpll.c' that is almost entirely free of direct register I/O, and all state logic is properly encapsulated in its respective file. The series is broken down as follows: * Patch 1: Changes the state structs to store raw register values (e.g., 'config', 'ctrl') instead of parsed booleans, centralizing parsing logic into the helpers. * Patch 2: Splits the logic from 'core.c' into new 'ref.c', 'out.c' and 'synth.c' files, creating a 'zl3073x_dev_...' abstraction layer. * Patch 3: Introduces the caching concept by reading and caching the reference monitor status periodically, removing scattered reads from 'dpll.c'. * Patch 4: Expands the 'zl3073x_ref' struct to cache *all* reference properties and adds 'zl3073x_ref_state_set()' to write back changes. * Patch 5: Does the same for the 'zl3073x_out' struct, caching all output properties and adding 'zl3073x_out_state_set()'. * Patch 6: A final cleanup that removes the 'zl3073x_dev_...' wrapper functions that became redundant after the refactoring. Changes: v2: - addressed issues found by patchwork bot (details in each patch) Ivan Vecera (6): dpll: zl3073x: Store raw register values instead of parsed state dpll: zl3073x: Split ref, out, and synth logic from core dpll: zl3073x: Cache reference monitor status dpll: zl3073x: Cache all reference properties in zl3073x_ref dpll: zl3073x: Cache all output properties in zl3073x_out dpll: zl3073x: Remove unused dev wrappers drivers/dpll/zl3073x/Makefile | 3 +- drivers/dpll/zl3073x/core.c | 243 +---------- drivers/dpll/zl3073x/core.h | 184 +++----- drivers/dpll/zl3073x/dpll.c | 776 ++++++++-------------------------- drivers/dpll/zl3073x/out.c | 157 +++++++ drivers/dpll/zl3073x/out.h | 93 ++++ drivers/dpll/zl3073x/prop.c | 12 +- drivers/dpll/zl3073x/ref.c | 194 +++++++++ drivers/dpll/zl3073x/ref.h | 134 ++++++ drivers/dpll/zl3073x/synth.c | 87 ++++ drivers/dpll/zl3073x/synth.h | 72 ++++ 11 files changed, 1009 insertions(+), 946 deletions(-) create mode 100644 drivers/dpll/zl3073x/out.c create mode 100644 drivers/dpll/zl3073x/out.h create mode 100644 drivers/dpll/zl3073x/ref.c create mode 100644 drivers/dpll/zl3073x/ref.h create mode 100644 drivers/dpll/zl3073x/synth.c create mode 100644 drivers/dpll/zl3073x/synth.h -- 2.51.0