All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	stable@dpdk.org, Byron Marohn <byron.marohn@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>,
	Christian Maciocco <christian.maciocco@intel.com>
Subject: [PATCH v2 1/7] examples/server_node_efd: fix format overflow
Date: Tue, 11 Nov 2025 14:17:18 -0800	[thread overview]
Message-ID: <20251111221857.443752-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20251111221857.443752-1-stephen@networkplumber.org>

If format-truncation is enabled, the compiler detects a string overflow
since the snprintf() is putting ethernet address and new line
in buffer only sized for the address.

Since get_rx_queue_name() is used to create a ring name.
The buffer should be sized to be a valid ring name.
This fixes some format-overflow warnings and also corrects
for future errors.

Fixes: 39aad0e88c58 ("examples/flow_distributor: new example to demonstrate EFD")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/server_node_efd/efd_server/main.c | 2 +-
 examples/server_node_efd/shared/common.h   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/examples/server_node_efd/efd_server/main.c b/examples/server_node_efd/efd_server/main.c
index 75ff0ea532..62c3f4a16d 100644
--- a/examples/server_node_efd/efd_server/main.c
+++ b/examples/server_node_efd/efd_server/main.c
@@ -68,7 +68,7 @@ static const char *
 get_printable_mac_addr(uint16_t port)
 {
 	static const char err_address[] = "00:00:00:00:00:00";
-	static char addresses[RTE_MAX_ETHPORTS][sizeof(err_address)];
+	static char addresses[RTE_MAX_ETHPORTS][RTE_ETHER_ADDR_FMT_SIZE + 1];
 	struct rte_ether_addr mac;
 	int ret;
 
diff --git a/examples/server_node_efd/shared/common.h b/examples/server_node_efd/shared/common.h
index e1ab7e62b7..6726e2031e 100644
--- a/examples/server_node_efd/shared/common.h
+++ b/examples/server_node_efd/shared/common.h
@@ -58,8 +58,9 @@ get_rx_queue_name(unsigned int id)
 	/*
 	 * Buffer for return value. Size calculated by %u being replaced
 	 * by maximum 3 digits (plus an extra byte for safety)
+	 * Used as ring name, so upper limit is ring name size.
 	 */
-	static char buffer[sizeof(MP_NODE_RXQ_NAME) + 2];
+	static char buffer[RTE_RING_NAMESIZE];
 
 	snprintf(buffer, sizeof(buffer), MP_NODE_RXQ_NAME, id);
 	return buffer;
-- 
2.51.0


  reply	other threads:[~2025-11-11 22:19 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 18:19 [PATCH 0/3] examples: format truncation bugs Stephen Hemminger
2025-11-10 18:19 ` [PATCH 1/3] examples/server_node_efd: fix format overflow Stephen Hemminger
2025-11-10 18:19 ` [PATCH 2/3] examples/vdpa: fix format overflow warning Stephen Hemminger
2025-11-10 18:19 ` [PATCH 3/3] examples: re-enable format truncation warning Stephen Hemminger
2025-11-11 22:17 ` [PATCH v2 0/7] fix format-truncation warnings Stephen Hemminger
2025-11-11 22:17   ` Stephen Hemminger [this message]
2025-11-11 22:17   ` [PATCH v2 2/7] examples/vdpa: fix format overflow warning Stephen Hemminger
2025-11-14 15:59     ` Bruce Richardson
2025-11-11 22:17   ` [PATCH v2 3/7] examples/ip_reassembly: add check before formatting name Stephen Hemminger
2025-11-12 14:50     ` Konstantin Ananyev
2025-11-14 16:05     ` Bruce Richardson
2025-11-11 22:17   ` [PATCH v2 4/7] examples: re-enable format truncation warning Stephen Hemminger
2025-11-14 16:07     ` Bruce Richardson
2025-11-11 22:17   ` [PATCH v2 5/7] test: refactor file prefix arg handling Stephen Hemminger
2025-11-11 22:17   ` [PATCH v2 6/7] test: increase size of memzone name Stephen Hemminger
2025-11-14 16:07     ` Bruce Richardson
2025-11-11 22:17   ` [PATCH v2 7/7] test: re-enable format-truncation warnings Stephen Hemminger
2025-11-14 16:08     ` Bruce Richardson
2025-11-15 19:36 ` [PATCH v3 0/4] examples: fix " Stephen Hemminger
2025-11-15 19:36   ` [PATCH v3 1/4] examples/server_node_efd: fix format overflow Stephen Hemminger
2025-11-17  8:50     ` Bruce Richardson
2025-11-15 19:36   ` [PATCH v3 2/4] examples/vdpa: fix format overflow warning Stephen Hemminger
2025-11-19  4:31     ` Thomas Monjalon
2025-11-19  9:13       ` Bruce Richardson
2025-11-15 19:36   ` [PATCH v3 3/4] examples/ip_reassembly: add check before formatting name Stephen Hemminger
2025-11-15 19:36   ` [PATCH v3 4/4] examples: enable format truncation warning Stephen Hemminger
2025-11-20 16:21 ` [PATCH v4 0/4] examples: fix format-truncation errors Stephen Hemminger
2025-11-20 16:21   ` [PATCH v4 1/4] examples/server_node_efd: fix format overflow Stephen Hemminger
2025-11-20 16:22   ` [PATCH v4 2/4] examples/vdpa: fix format overflow warning Stephen Hemminger
2025-11-20 16:22   ` [PATCH v4 3/4] examples/ip_reassembly: add check before formatting name Stephen Hemminger
2025-11-20 16:22   ` [PATCH v4 4/4] examples: enable format truncation warning Stephen Hemminger
2025-11-24 16:20   ` [PATCH v4 0/4] examples: fix format-truncation errors David Marchand
2025-11-21 17:08 ` [PATCH v5 0/8] tests: fix format truncation warnings Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 1/8] test: increase size of memzone name Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 2/8] test: refactor file prefix arg handling Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 3/8] test: avoid overflowing huge directory path Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 4/8] test: use unit test runner for eal flags Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 5/8] test: fix format overflow warning in ACL test Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 6/8] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 7/8] test: fix format overflow in cryptodev test Stephen Hemminger
2025-11-21 17:08   ` [PATCH v5 8/8] test: re-enable format-truncation warnings Stephen Hemminger
2025-11-23 17:43 ` [PATCH v6 0/9] tests: fix format truncation warnings Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 1/9] test: increase size of memzone name Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 2/9] test: refactor file prefix arg handling Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 3/9] test: avoid overflowing huge directory path Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 4/9] test: use unit test runner for eal flags Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 5/9] test: fix format overflow warning in ACL test Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 6/9] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 7/9] test: fix format overflow in cryptodev test Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 8/9] test: fix overflow warnings in mp_secondary and pdump Stephen Hemminger
2025-11-23 17:43   ` [PATCH v6 9/9] test: re-enable format-truncation warnings Stephen Hemminger
2025-11-24  1:53   ` [PATCH v6 0/9] tests: fix format truncation warnings fengchengwen
2025-11-24 15:45   ` Patrick Robb
2025-11-25 15:20 ` [PATCH v7 00/10] test: " Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 01/10] test: increase size of memzone name Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 02/10] test: add new function to get current file-prefix arg Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 03/10] test: refactor file prefix arg handling Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 04/10] test: avoid overflowing huge directory path Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 05/10] test: fix format overflow warning in ACL test Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 06/10] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 07/10] test: fix format overflow in cryptodev test Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 08/10] test: fix overflow warnings in several places by using common code Stephen Hemminger
2025-11-25 15:20   ` [PATCH v7 09/10] test: use unit test runner for eal flags Stephen Hemminger
2025-11-25 15:21   ` [PATCH v7 10/10] test: re-enable format-truncation warnings Stephen Hemminger
2025-11-28 22:42 ` [PATCH v8 00/10] test: cleanup and format truncation fixes Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 01/10] test: increase size of memzone name Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 02/10] test: add new function to get current file-prefix arg Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 03/10] test: refactor file prefix arg handling Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 04/10] test: avoid overflowing huge directory path Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 05/10] test: fix format overflow warning in ACL test Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 06/10] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 07/10] test: fix format overflow in cryptodev test Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 08/10] test: fix overflow warnings in several places by using common code Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 09/10] test: use unit test runner for eal flags Stephen Hemminger
2025-11-28 22:42   ` [PATCH v8 10/10] test: re-enable format-truncation warnings Stephen Hemminger
2025-12-01 22:01 ` [PATCH v9 0/9] test: cleanup and format truncation fixes Stephen Hemminger
2025-12-01 22:01   ` [PATCH v9 1/9] test: increase size of memzone name Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 2/9] test: add new function to get current file-prefix arg Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 3/9] test: refactor file prefix arg handling Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 4/9] test: avoid overflowing huge directory path Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 5/9] test: fix format overflow warning in ACL test Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 6/9] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 7/9] test: fix format overflow in cryptodev test Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 8/9] test: fix overflow warnings in several places by using common code Stephen Hemminger
2025-12-01 22:02   ` [PATCH v9 9/9] test: re-enable format-truncation warnings Stephen Hemminger
2025-12-29 21:59 ` [PATCH v10 0/9] tests: enable and fix format overflow Stephen Hemminger
2025-12-29 21:59   ` [PATCH v10 1/9] test: increase size of memzone name Stephen Hemminger
2025-12-29 21:59   ` [PATCH v10 2/9] test: add new function to get current file-prefix arg Stephen Hemminger
2026-01-02 12:50     ` Marat Khalili
2026-01-02 17:10       ` Stephen Hemminger
2025-12-29 21:59   ` [PATCH v10 3/9] test: refactor file prefix arg handling Stephen Hemminger
2026-01-02 14:03     ` Marat Khalili
2025-12-29 21:59   ` [PATCH v10 4/9] test: avoid overflowing huge directory path Stephen Hemminger
2026-01-02 14:27     ` Marat Khalili
2025-12-29 21:59   ` [PATCH v10 5/9] test: fix format overflow warning in ACL test Stephen Hemminger
2026-01-02 14:33     ` Marat Khalili
2025-12-29 21:59   ` [PATCH v10 6/9] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2026-01-02 14:47     ` Marat Khalili
2025-12-29 21:59   ` [PATCH v10 7/9] test: fix format overflow in cryptodev test Stephen Hemminger
2025-12-29 21:59   ` [PATCH v10 8/9] test: fix overflow warnings in common code Stephen Hemminger
2026-01-02 14:54     ` Marat Khalili
2025-12-29 21:59   ` [PATCH v10 9/9] test: re-enable format-truncation warnings Stephen Hemminger
2026-01-02 14:55     ` Marat Khalili
2026-01-17  2:36 ` [PATCH v11 0/6] tests: enable format-overflow and fix warnings Stephen Hemminger
2026-01-17  2:36   ` [PATCH v11 1/6] test: increase size of memzone name Stephen Hemminger
2026-01-17  2:36   ` [PATCH v11 2/6] test: add new function to get current file-prefix arg Stephen Hemminger
2026-01-17  2:36   ` [PATCH v11 3/6] test: avoid overflowing huge directory path Stephen Hemminger
2026-01-17  2:36   ` [PATCH v11 4/6] test: fix format overflow warning in ACL test Stephen Hemminger
2026-01-17  2:37   ` [PATCH v11 5/6] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2026-01-17  2:37   ` [PATCH v11 6/6] test: fix format overflow in cryptodev test Stephen Hemminger
2026-01-21 21:06 ` [PATCH v12 0/8] test: fix format-truncation warnings Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 1/8] test: increase size of memzone name Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 2/8] test: add new function to get current file-prefix arg Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 3/8] test: avoid overflowing huge directory path Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 4/8] test: fix format overflow warning in ACL test Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 5/8] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 6/8] test: fix format overflow in cryptodev test Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 7/8] test: fix overflow warnings in common code Stephen Hemminger
2026-01-21 21:06   ` [PATCH v12 8/8] test: re-enable format-truncation warnings Stephen Hemminger
2026-02-06 11:21   ` [PATCH v12 0/8] test: fix " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111221857.443752-2-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=byron.marohn@intel.com \
    --cc=christian.maciocco@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=saikrishna.edupuganti@intel.com \
    --cc=stable@dpdk.org \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.