All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Lance Yang <lance.yang@linux.dev>
Cc: Wei Yang <richard.weiyang@gmail.com>,
	linux-mm@kvack.org, baolin.wang@linux.alibaba.com,
	dev.jain@arm.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com,
	npache@redhat.com, baohua@kernel.org, akpm@linux-foundation.org,
	david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com
Subject: Re: [PATCH] mm/khugepaged: continue to collapse on SCAN_PMD_NONE
Date: Wed, 12 Nov 2025 03:40:08 +0000	[thread overview]
Message-ID: <20251112034008.ojwghkko74psu65v@master> (raw)
In-Reply-To: <06096f8b-4da0-4b5c-af3c-fd8871437c16@linux.dev>

On Wed, Nov 12, 2025 at 10:37:06AM +0800, Lance Yang wrote:
>
>
>On 2025/11/12 10:00, Wei Yang wrote:
>> SCAN_PMD_NONE means current pmd is empty, but we can still continue
>> collapse next pmd range.
>
>Right, bailing out of the whole MADV_COLLAPSE request just because
>we encounter one empty PMD is too strict ...
>
>It makes sense to treat SCAN_PMD_NONE like the other whitelisted cases
>(e.g., SCAN_PMD_NULL).
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> ---
>
>LGTM.
>
>Reviewed-by: Lance Yang <lance.yang@linux.dev>
>

Thanks for the review.

I'm currently evaluating the use of SCAN_NULL versus SCAN_NONE. It seems their
usage in the current code is intermixed, and I'm questioning if there's a
strong, practical reason to maintain a distinction between these two states.
Should they be unified?


-- 
Wei Yang
Help you, Help me


  reply	other threads:[~2025-11-12  3:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12  2:00 [PATCH] mm/khugepaged: continue to collapse on SCAN_PMD_NONE Wei Yang
2025-11-12  2:37 ` Lance Yang
2025-11-12  3:40   ` Wei Yang [this message]
2025-11-12  3:58     ` Dev Jain
2025-11-12  9:10       ` Wei Yang
2025-11-12  3:33 ` Dev Jain
2025-11-12  9:51 ` David Hildenbrand (Red Hat)
2025-11-12  9:51   ` David Hildenbrand (Red Hat)
2025-11-12 11:27     ` Wei Yang
2025-11-12 11:41       ` David Hildenbrand (Red Hat)
2025-11-13  2:44 ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112034008.ojwghkko74psu65v@master \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.