From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EA2ECCFA1A for ; Wed, 12 Nov 2025 14:23:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4CBD10E749; Wed, 12 Nov 2025 14:23:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="JBo3o4zb"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C1C210E749 for ; Wed, 12 Nov 2025 14:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1762957425; bh=1y8Od7Xh9l2hezr7urT6bLDtz1I1ySxP+ZueOMZZHsM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JBo3o4zb1JLLbr1XT7UAAi4htgKKiFDgd7aEJPH5Qdzj4PWSubQiKRZ/aaD/KJVC4 xNsp2fGdaxvpsXhnLjNEYWIRU2aMLDHu/w4vC8wfibRiFLehlLOZ4VN/MVOJjSrg2G vLJaLdSAu4Yj4hWXDrEm48UQp3v+nUzL2Sy5bEQXgDRUGDXEyT7XaJU5fY49Ea8cE1 LjB33+VvZ+k19n4QzOEFEIGxcdej8a2WyaNsQXDdwSyjqkldHvisT6Xh+JSLconcZf /8upHb7g67YuoIAsooLIAa4Rgs/FyDHvkNQU7sqjJEMNSeR4x6WaqjvM3bQ1QtjIYN jJI5mUKZlST9g== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7CB3617E0364; Wed, 12 Nov 2025 15:23:45 +0100 (CET) Date: Wed, 12 Nov 2025 15:23:40 +0100 From: Boris Brezillon To: Philipp Stanner Cc: Steven Price , Liviu Dudau , =?UTF-8?B?QWRyacOhbg==?= Larumbe , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Detlev Casanova , Ashley Smith , kernel@collabora.com Subject: Re: [PATCH v7 1/2] drm/panthor: Make the timeout per-queue instead of per-job Message-ID: <20251112152340.40f72b7e@fedora> In-Reply-To: <20251112151253.7cfba768@fedora> References: <20251112121744.1356882-1-boris.brezillon@collabora.com> <20251112121744.1356882-2-boris.brezillon@collabora.com> <7cea7efb7ff0ab34ab7352158ecce731a3f714d8.camel@redhat.com> <20251112143104.2cabebb9@fedora> <0558310f433debe93dddee0b6373bcb406b8bd62.camel@redhat.com> <20251112151253.7cfba768@fedora> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 12 Nov 2025 15:12:53 +0100 Boris Brezillon wrote: > > OK. timeout_wq sharing is intended and allowed, so if that's what > > you're doing, good. But I agree that accessing the wq through the > > driver's struct is then cleaner and more obviously correct. > > Will do. Actually, after looking into that, it seems I'd have to go back to dev_get_drvdata(drm_gpu_scheduler::dev)::reset_wq to get the timeout workqueue, so I think I'd prefer to keep using drm_gpu_scheduler::timeout_wq unless that's really seen as a layering violation (but I'd argue that accessing drm_gpu_scheduler::dev looks like the same kind of layering violation to me).