Re: [PATCH 4/5] iomap: support write completions from interrupt context

[Christoph Hellwig <hch@lst.de>]

On Wed, Nov 12, 2025 at 09:25:58PM +0100, Jan Kara wrote:
> > +
> > +		/*
> > +		 * We can only do inline completion for pure overwrites that
> > +		 * don't require additional I/O at completion time.
> > +		 *
> > +		 * This rules out writes that need zeroing or extent conversion,
> > +		 * or extend the file size.
> > +		 */
> > +		if (!iomap_dio_is_overwrite(iomap))
> > +			dio->flags &= ~IOMAP_DIO_INLINE_COMP;
> >  	} else {
> >  		bio_opf |= REQ_OP_READ;
> >  	}
> 
> OK, now I see why you wrote iomap_dio_is_overwrite() the way you did. You
> still want to keep completions inline for overwrites of possibly
> uncommitted extents.

Yes.

> But I have to admit it all seems somewhat fragile and
> difficult to follow. Can't we just check for IOMAP_DIO_UNWRITTEN |
> IOMAP_DIO_COW | IOMAP_DIO_NEED_SYNC in flags (plus the i_size check) and be
> done with it?

You mean drop the common helper?  How would that be better and less
fragile?   Note that I care strongly, but I don't really see the point.