From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943C9DDD2 for ; Thu, 13 Nov 2025 08:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763022300; cv=none; b=ADrXEQp3+N0dxYn227tOahRk/sdh1VE5Q/74fAujy3LtQUlS5BafTHC9sRK5IEbPzrlCVoRWBwwpbZiG/vbUTcAo4zvTDvFU+bu3NMOBbG1kQvxd7qcRSdj94GN3TncdvOTxoJrjuBjtYCkdJth+wy4N6+HKYri11Xa2IaajDDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763022300; c=relaxed/simple; bh=pXLpg1P+NszGM8RZ98JaLiDfJk2ejEBhbCKCWa8Wy4o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=g5vltt6ZnzIAmaHGPFLqDuGyC42S1ATfelTYYH0gNca+Pkr814+dh0Gsqlezr2q+Rkib0bfwB/b92R+iMa32i1ZAJwP9C9jvjnJPz4qA2R7Q+4DBrWQ3EK0PaVNgAqCiWSUs6FJSQ+BajBvElprfpKxxbaaB6oBlSaGQRx+ZbUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z6+m9Kgg; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z6+m9Kgg" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2953ad5517dso6473975ad.0 for ; Thu, 13 Nov 2025 00:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763022299; x=1763627099; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E29I21iTFgmKy+IbzDTMyuzYhhbOKWzxr4diSFn7ScU=; b=Z6+m9Kgg4ATLxOnbYbxDYu3dpm05yxztNZa8oQ1pGTD3kk9DR5YRcxn4TcSSbC3Nuq 2kI8VJTcTVuLj2N3P8x1sXf/zYvzJfCR1nCx2SIFBRTLNQBbu9NX/XaXUxR2xR/RG2eY WmfjJoEtBkzxY/G57J7RkhV4FaTfHYswK8/U8CFBvHeu0HWNjTTrvP95P4vZ4G5udc/6 rTHN3A93A+CfRaX0UrD0MjqQ9intF/RYDGB2+khUaZ+9W95LU0kIzlTEi1VmnnstO+sF 6k7WhvHAhs1JepKhG+Z4igiU9J8ZxfWXfpFH+hIBRMX3TO+t5d5ObsSOJZblvx6m+9nC 8qMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763022299; x=1763627099; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E29I21iTFgmKy+IbzDTMyuzYhhbOKWzxr4diSFn7ScU=; b=k78mtnhs6xUci9C79CtkxtIS9hX6ERKBjYrE9BH8SmQfkh8Zy+KGsyT18Z2ToZgmke LhygqvOgV6fxYm8zxSKfDiuW0CmBnxHydtcS/esGjsXOftyHopEL2pvT8HvTZz1fMuHZ ToQX+Psa9u0xFY+oHWKcOBP0jRujFbytgu35PNZBmXfMTyUPyZXI2Jn3iJB1sS6bIRWB iYJg4A4Kgzmm5QhkirlSqijJtM7jvdLLAI02DDFmvLU8q2HbI1qjX/+dM9yxZLJKQE81 8PJ6XUDu9FlX7qyB7zMFky7OV8oNkHMKdvtZ2GOYk6xN19ZyxTtCGLr5Vcr1WySJkveZ LR+w== X-Forwarded-Encrypted: i=1; AJvYcCWmBXWoLp196bZarrwX2CEs9Wnt/uw8Io/ugRbxLJQovNd5L4uxI6WcFtz2LIXMYoe5elg=@vger.kernel.org X-Gm-Message-State: AOJu0YwPkMWy7JfTBfnNMMh+DyZUhzbSBWZgfiN2UXoqDi4mCzNWHKXm mDp/WOUpD1K3pCCVvZ5jgMMCZzilMfyfb5WiYeXTo44/VPKDLRvynmwh X-Gm-Gg: ASbGnctVSQcBRDpDKQZIifSUYctc3kLWyHjOAy5FazdJUgb6FF1Gc9Fi4LXGb+3yiWx BQ+kKdUO1dinZPHXPg2XyFuVKPnDw3aNlX4LxBnl9sxMuMkpKav0U3CN78U2jo2bRQxir2gQH5y pNX4ZubHmpiFQqZy9aaf/0cxvPGuGC5niqNvY7aPZ496c4KN+xO86lvBooM0+POCI+jGHRMhyJZ QApMe5miMcqM33n/cRBtryZLOzNJzilLaNUvGe/5MBSsl6V+ODJm24NHElfCZEDcI2ggL/rxN5f vHcaojhzLV22GpEncnvN+tcXsmtwNwerrT2y6tA4o6BSfvJhAO0IXj9ND+I7kzqCCMBitzYvqnr 7LyoywYLrwA1+m7AJjZksf+LUFx6SflYpd36R3a/KDAdhwRjdR8HVxAyy+mbRePJ5aVri+PHu6y N0bROwqBSo67M77ZJ/gqQQ1GQad5f2wz7VLlO2Dxw= X-Google-Smtp-Source: AGHT+IG6G8bRlTc+7WY76hJfvUTnoph43OEFDRSFR5ryUFHLWUxOfe6SWPhcIlsJWUCZ9XOhzdKiwg== X-Received: by 2002:a17:903:110f:b0:298:34b:492c with SMTP id d9443c01a7336-2984ee1df94mr76201095ad.54.1763022298884; Thu, 13 Nov 2025 00:24:58 -0800 (PST) Received: from localhost.localdomain ([103.246.102.164]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2b1055sm16332635ad.59.2025.11.13.00.24.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Nov 2025 00:24:58 -0800 (PST) From: Alessandro Decina To: netdev@vger.kernel.org Cc: Maciej Fijalkowski , "David S. Miller" , Alexei Starovoitov , Andrew Lunn , Daniel Borkmann , Eric Dumazet , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Paolo Abeni , Przemek Kitszel , Stanislav Fomichev , Tirthendu Sarkar , Tony Nguyen , bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Alessandro Decina Subject: [PATCH net v3 0/1] i40e: xsk: advance next_to_clean on status descriptors Date: Thu, 13 Nov 2025 19:24:37 +1100 Message-Id: <20251113082438.54154-1-alessandro.d@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, As suggested by Maciej, submitting v3 which makes i40e_clean_rx_irq and i40e_clean_rx_irq_zc use similar logic and a shared function i40e_inc_ntp_ntc() to advance next_to_process and next_to_clean when handling status descriptors. I've left the rest of the i40e_clean_rx_irq logic unchanged or this patch would snowball. I think it'd be nice to change the function to work with local variables and update the rx_ring only at the end like _zc, but seems out of scope for this patch. Changes since v2: * use common utility function i40e_inc_ntp_ntc to advance indexes Alessandro Decina (1): i40e: xsk: advance next_to_clean on status descriptors drivers/net/ethernet/intel/i40e/i40e_txrx.c | 33 ++++++++++++------- .../ethernet/intel/i40e/i40e_txrx_common.h | 2 ++ drivers/net/ethernet/intel/i40e/i40e_xsk.c | 17 ++++++---- 3 files changed, 34 insertions(+), 18 deletions(-) base-commit: 96a9178a29a6b84bb632ebeb4e84cf61191c73d5 -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C93DCD4F50 for ; Thu, 13 Nov 2025 08:25:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E01FE40CB7; Thu, 13 Nov 2025 08:25:02 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id C6XOy6SQqP7O; Thu, 13 Nov 2025 08:25:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 20C5440CC3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1763022302; bh=E29I21iTFgmKy+IbzDTMyuzYhhbOKWzxr4diSFn7ScU=; h=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=CQ1ESGpsh4U1tATw8pZWmllIK3hyEdY86wwl6XW7MUumT7MWOd3dM5ynY1mgnYwGL igwnFg/aV1MzBf1ulH1oIOf16TaipH1KzdASAcK6rOoqZUyTFbjxYfdb5u5pDMYYOH m3LRX4Tvio5bl79G9jnTABCExJh8XxuwhW1Y4z7+oWUxC2Mkh2BTfT9uOf27MbdSJn uqVZeKQ9Sa8wTQI701fzCRsuffPAmrVJyzCbbtwggcuTD/ZgSzvCBBGoCaZGR4G2GC 0Zz6+JTzFJft9Q4GsaK+IWeMWdRGKZv+nQPbs9cZCSfmhEbGiPDiDUfsJVgJhNtHrB rRl96qx2TZKKg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 20C5440CC3; Thu, 13 Nov 2025 08:25:02 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 6FE80342 for ; Thu, 13 Nov 2025 08:25:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6121B606F0 for ; Thu, 13 Nov 2025 08:25:00 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id e4eYlXC531UR for ; Thu, 13 Nov 2025 08:24:59 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::533; helo=mail-pg1-x533.google.com; envelope-from=alessandro.d@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org B7A6F6061E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B7A6F6061E Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by smtp3.osuosl.org (Postfix) with ESMTPS id B7A6F6061E for ; Thu, 13 Nov 2025 08:24:59 +0000 (UTC) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-bc1f6dfeb3dso327654a12.1 for ; Thu, 13 Nov 2025 00:24:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763022299; x=1763627099; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E29I21iTFgmKy+IbzDTMyuzYhhbOKWzxr4diSFn7ScU=; b=AILwF9nhtm9+innhOyFeq5r7OFPmYf1HlWagBfkUstgcVGwOH6HgcHJi8vT2YGr1jb FZ2FxmoppKzMem37+j9IitM/chjoBMUX3tBeNYTb8V9XKlO8FWpQO+Td4g7NM0QG69Qn BfPoxEy2kJH4UaCnu48QcXH5nfisrtb+byaNNuWNXFhCXWvld5QKZcvt85UgpArnuzHR 1AmLFRbzZmbgW45AYmncKIUcTuGNeXtEHesha6m/ViJvoUUWZXyjiN9+ufcYGCjUf13x ODbs40DYgJSQgxiFUp5a3mlcpvOpvFe8QYF0h+UBZsYmqIEkYN12E4TGvkNS2R9i1jjX KUCQ== X-Forwarded-Encrypted: i=1; AJvYcCW8Kum7BFA486jxG4HOMMWUMwUHRKthISeOuWYYP9/P/fk4iDpsdsnyN5ZMTWPMElUsyjCyRH6BBtudeOmeYos=@lists.osuosl.org X-Gm-Message-State: AOJu0YyRDSMjhfARtyWOnJ1o4f9HLCzRYdf8PZKBWGWOFVYnjjAvEOtY spPWMeusH1hLrJUtt3fR7HqGOX5Kgd7CQDHLxXjotw21mCr02p6LslpC X-Gm-Gg: ASbGncs4CXw3UarvwYto3cIHocgWc5aeE/9Hf3pa55T7uZsiupQF2trtGn+TTUP3pq4 JIWsvi1aXRLpQ8ywi1f0ursbFOjhznQjYHCp94kuw8S2IsbETffF4uuyyQ9TIbTfEG7wk80dft6 0MgSid6Iq1qxwiM1iX7LGtgPgG4KMAOU54ONO2Cu95InAbjSvGofPOCZ2Z72W/sRBinBP8CNyQB akjr3s5S/Pim7P0JHptG8wgWRNYpMQAC3KxAQzTc8ZAwH+/7wW+Q5ufp3obeq9X04qO5AASPxAm 5cWnT9WJvOE4DFiDEWFjt8jpFjWtQtDAiYCx5ac9e3tcY1UWGyGl646BUUtZG9AUVeDRFcIQGVB GcLt+jVxd7i8KWunHX+nFByOUx8xSnqx3FVSKpt0ol2RO71V64rhTTj4gZIHPkWKfB7KleO4RtG C4UJPnl75AXK08haPIVNPViJxmlFOyKOeNSBGeOqI= X-Google-Smtp-Source: AGHT+IG6G8bRlTc+7WY76hJfvUTnoph43OEFDRSFR5ryUFHLWUxOfe6SWPhcIlsJWUCZ9XOhzdKiwg== X-Received: by 2002:a17:903:110f:b0:298:34b:492c with SMTP id d9443c01a7336-2984ee1df94mr76201095ad.54.1763022298884; Thu, 13 Nov 2025 00:24:58 -0800 (PST) Received: from localhost.localdomain ([103.246.102.164]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2b1055sm16332635ad.59.2025.11.13.00.24.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Nov 2025 00:24:58 -0800 (PST) From: Alessandro Decina To: netdev@vger.kernel.org Cc: Maciej Fijalkowski , "David S. Miller" , Alexei Starovoitov , Andrew Lunn , Daniel Borkmann , Eric Dumazet , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Paolo Abeni , Przemek Kitszel , Stanislav Fomichev , Tirthendu Sarkar , Tony Nguyen , bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Alessandro Decina Date: Thu, 13 Nov 2025 19:24:37 +1100 Message-Id: <20251113082438.54154-1-alessandro.d@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763022299; x=1763627099; darn=lists.osuosl.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E29I21iTFgmKy+IbzDTMyuzYhhbOKWzxr4diSFn7ScU=; b=jqFZ4/uFj4NvB71LEWL8WV5pI6EkZqwIz2D9hhAohtuHIZRLXcHzyZ6mL1VwvS8aSG J6PiXyw+XqmGRLYRZGO7jkLj4aWjGoF8dw29e+hm4XcoDyIV7ZxMw8uL58M8wJFtkfUi VWQ7QstOZPmqK8+knq77AzcOmV75XSp8ymfJQsMV6RWNBw+MGsaO0XfeMTO5sAzIY5Wo 9t19zTHmmKyTJv23zc62QAo7ZiVudrNK/xF7OP3TI73lt95LmvB1bmbquPuHKuvCgYob VmwF7iby9kh1VRQtwLANJCX0lSkSgeENAb+P6ws1Adi13WMqn/z5mAhRBnTPDo50c/7Y H6Ug== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=jqFZ4/uF Subject: [Intel-wired-lan] [PATCH net v3 0/1] i40e: xsk: advance next_to_clean on status descriptors X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hello, As suggested by Maciej, submitting v3 which makes i40e_clean_rx_irq and i40e_clean_rx_irq_zc use similar logic and a shared function i40e_inc_ntp_ntc() to advance next_to_process and next_to_clean when handling status descriptors. I've left the rest of the i40e_clean_rx_irq logic unchanged or this patch would snowball. I think it'd be nice to change the function to work with local variables and update the rx_ring only at the end like _zc, but seems out of scope for this patch. Changes since v2: * use common utility function i40e_inc_ntp_ntc to advance indexes Alessandro Decina (1): i40e: xsk: advance next_to_clean on status descriptors drivers/net/ethernet/intel/i40e/i40e_txrx.c | 33 ++++++++++++------- .../ethernet/intel/i40e/i40e_txrx_common.h | 2 ++ drivers/net/ethernet/intel/i40e/i40e_xsk.c | 17 ++++++---- 3 files changed, 34 insertions(+), 18 deletions(-) base-commit: 96a9178a29a6b84bb632ebeb4e84cf61191c73d5 -- 2.43.0