From: Eric Biggers <ebiggers@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs()
Date: Thu, 13 Nov 2025 09:19:06 -0800 [thread overview]
Message-ID: <20251113171906.GB1792@sol> (raw)
In-Reply-To: <20251113114501.32905-1-yuehaibing@huawei.com>
On Thu, Nov 13, 2025 at 07:45:01PM +0800, Yue Haibing wrote:
> Commit bf40785fa437 ("sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk
> authentication") removed the implementation but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/net/sctp/auth.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/sctp/auth.h b/include/net/sctp/auth.h
> index 3d5879e08e78..6f2cd562b1de 100644
> --- a/include/net/sctp/auth.h
> +++ b/include/net/sctp/auth.h
> @@ -72,7 +72,6 @@ struct sctp_shared_key *sctp_auth_get_shkey(
> int sctp_auth_asoc_copy_shkeys(const struct sctp_endpoint *ep,
> struct sctp_association *asoc,
> gfp_t gfp);
> -int sctp_auth_init_hmacs(struct sctp_endpoint *ep, gfp_t gfp);
> const struct sctp_hmac *sctp_auth_get_hmac(__u16 hmac_id);
> const struct sctp_hmac *
> sctp_auth_asoc_get_hmac(const struct sctp_association *asoc);
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
- Eric
next prev parent reply other threads:[~2025-11-13 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:45 [PATCH net-next] sctp: Remove unused declaration sctp_auth_init_hmacs() Yue Haibing
2025-11-13 17:19 ` Eric Biggers [this message]
2025-11-15 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113171906.GB1792@sol \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.