Re: [PATCH net-next 3/8] ovpn: notify userspace on client float event

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 11 Nov 2025 22:47:36 +0100 Antonio Quartulli wrote:
> +	if (ss->ss_family == AF_INET) {
> +		sa = (struct sockaddr_in *)ss;
> +		if (nla_put_in_addr(msg, OVPN_A_PEER_REMOTE_IPV4,
> +				    sa->sin_addr.s_addr) ||
> +		    nla_put_net16(msg, OVPN_A_PEER_REMOTE_PORT, sa->sin_port))
> +			goto err_cancel_msg;
> +	} else if (ss->ss_family == AF_INET6) {
> +		sa6 = (struct sockaddr_in6 *)ss;
> +		if (nla_put_in6_addr(msg, OVPN_A_PEER_REMOTE_IPV6,
> +				     &sa6->sin6_addr) ||
> +		    nla_put_u32(msg, OVPN_A_PEER_REMOTE_IPV6_SCOPE_ID,
> +				sa6->sin6_scope_id) ||
> +		    nla_put_net16(msg, OVPN_A_PEER_REMOTE_PORT, sa6->sin6_port))
> +			goto err_cancel_msg;
> +	} else {

presumably on this branch ret should be set to something?

> +		goto err_cancel_msg;
> +	}