From: Farhan Ali <alifm@linux.ibm.com>
To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Cc: helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org,
clg@redhat.com, stable@vger.kernel.org, alifm@linux.ibm.com,
schnelle@linux.ibm.com, mjrosato@linux.ibm.com,
Benjamin Block <bblock@linux.ibm.com>
Subject: [PATCH v5 4/9] PCI: Add additional checks for flr reset
Date: Thu, 13 Nov 2025 10:34:57 -0800 [thread overview]
Message-ID: <20251113183502.2388-5-alifm@linux.ibm.com> (raw)
In-Reply-To: <20251113183502.2388-1-alifm@linux.ibm.com>
If a device is in an error state, then any reads of device registers can
return error value. Add addtional checks to validate if a device is in an
error state before doing an flr reset.
Cc: <stable@vger.kernel.org>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
---
drivers/pci/pci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 3a9a283b5be9..4f03b1c730cf 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4525,12 +4525,19 @@ EXPORT_SYMBOL_GPL(pcie_flr);
*/
int pcie_reset_flr(struct pci_dev *dev, bool probe)
{
+ u32 reg;
+
if (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)
return -ENOTTY;
if (!(dev->devcap & PCI_EXP_DEVCAP_FLR))
return -ENOTTY;
+ if (pcie_capability_read_dword(dev, PCI_EXP_DEVCAP, ®)) {
+ pci_warn(dev, "Device unable to do an FLR\n");
+ return -ENOTTY;
+ }
+
if (probe)
return 0;
--
2.43.0
next prev parent reply other threads:[~2025-11-13 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 18:34 [PATCH v5 0/9] Error recovery for vfio-pci devices on s390x Farhan Ali
2025-11-13 18:34 ` [PATCH v5 1/9] PCI: Allow per function PCI slots Farhan Ali
2025-11-13 18:34 ` [PATCH v5 2/9] s390/pci: Add architecture specific resource/bus address translation Farhan Ali
2025-11-13 18:34 ` [PATCH v5 3/9] PCI: Avoid saving error values for config space Farhan Ali
2025-11-13 18:36 ` kernel test robot
2025-11-13 18:34 ` Farhan Ali [this message]
2025-11-13 18:34 ` [PATCH v5 5/9] s390/pci: Update the logic for detecting passthrough device Farhan Ali
2025-11-13 18:34 ` [PATCH v5 6/9] s390/pci: Store PCI error information for passthrough devices Farhan Ali
2025-11-13 18:35 ` [PATCH v5 7/9] vfio-pci/zdev: Add a device feature for error information Farhan Ali
2025-11-13 18:35 ` [PATCH v5 8/9] vfio: Add a reset_done callback for vfio-pci driver Farhan Ali
2025-11-13 18:35 ` [PATCH v5 9/9] vfio: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113183502.2388-5-alifm@linux.ibm.com \
--to=alifm@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=bblock@linux.ibm.com \
--cc=clg@redhat.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mjrosato@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.