From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4926C2F99A5 for ; Thu, 13 Nov 2025 20:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763065999; cv=none; b=KtXAXEjMIxpMNyCi4os9xBXl2cRXqUfF1jVteclGCYY75/TkzW+TkWPXGzyX9avqRdN4860qwUVWom5O+QIYOQ4S3oB3/+fR1XYk6sM8/PvuVS07B7rbcSG6Zn38HLqdg3r4smLDEGbaIHH//Nu7UB7lmT6927ey2NHNwk6GnQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763065999; c=relaxed/simple; bh=ZalGVvn6JWCBxTCoyrPuMcoW/dfbgIyV52AhxX9o4uw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bZALZasTvE2rIZbo6JS0U9Y2qVC8gmQ9EVrGVq2D0IoOoZu8UseZfTE1sgPecsKK4yanhS4SzRBWzG3P04MwMgaWZCx6b1j16OvGVxIzu+oexEYZIFLs1tdleF8eFDvYlrL1XpebBMyDVvDxGqPq1UkKjv+mnHrJYRzOOjvbcok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=yJLMkwTT; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=e3xMdiPI; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="yJLMkwTT"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="e3xMdiPI" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 688FC14000CB; Thu, 13 Nov 2025 15:33:15 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Thu, 13 Nov 2025 15:33:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1763065995; x= 1763152395; bh=4iEHkKhk3U2FIUKVqiaCbB7GA5IU2vkfZs/NSD1kjyk=; b=y JLMkwTTZYVBn9KQ4TpqzwBdqw4DRBuwgHc/7YcvZlObveFKF1NwigNSZv6BT76PF 7hCbk8c01rLw3JcVVp001t04D4idjTuNCNQRiWT7dmzOckpxn0Y0PrerfanZ9+/k mtF0VxVzPz10nKDfTCnjObf/0TH0crD/o1+DscBqNNS1ZC/0L5JDoNOT/Iz4ZmNN WLTwqH4rU14l+8R4Ll9mpOPigFZalOnQFeJt1fYFIYMEyqCnGc/aCIuNW9PB5E2J KZ22sRbA2SugjE2+0GeXRTP7BbyTvdstddnaclGYET+o+KrhUtWcz4bY3T4YqTx8 Qxs/qCUjDzihFzWv/3llg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1763065995; x=1763152395; bh=4iEHkKhk3U2FIUKVqiaCbB7GA5IU2vkfZs/ NSD1kjyk=; b=e3xMdiPIgmfBlKS82b9IHGTPDKclNnZppF8ESoL3Q+Hx0RP8LAB bZ/hz+aGtks+hY4uNedmTRr6AKLHDijSvvEyhjtGi8YOlcB0liZZDTEd0Ff1Rcsq Ji8zITBpPO7WIolsPihedyzOz9TlFCQqNDfsnl5Mq6A4oQsiGfjIb1hOAwyLOYrZ JzCkDlBKTbx7quK0tCdSClQs0BLgwtsUvIoDHmuQiYTC0fhr3F/OqFJIjsDViJVU rhxTMT2MHIytz0VJIYPtl8o1wR6LEAUtsNE80jnVc7b6Egrpb/JI5JdxURv+6AiP k5IcCt9btjH6wjOFQSEJWvR59v+SLJ9u08Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdejleduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttdertd dttddvnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpeehhffhteetgf ekvdeiueffveevueeftdelhfejieeitedvleeftdfgfeeuudekueenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Nov 2025 15:33:14 -0500 (EST) Date: Fri, 14 Nov 2025 05:33:11 +0900 From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: core: abort pending transactions at card removal Message-ID: <20251113203311.GA383705@workstation.local> Mail-Followup-To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20251111223834.311287-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251111223834.311287-1-o-takashi@sakamocchi.jp> On Wed, Nov 12, 2025 at 07:38:34AM +0900, Takashi Sakamoto wrote: > IEEE 1394 defines the split, concatenated, and unified transaction. > To support the split transaction, core function uses linked list to > maintain the transactions waiting for acknowledge packet. After clearing > sources of hardware interrupts, the acknowledge packet is no longer > handled, therefore it is required to abort the pending transactions. > > This commit executes callback with RCODE_CANCELLED for the pending > transactions at card removal. > > Signed-off-by: Takashi Sakamoto > --- > drivers/firewire/core-card.c | 1 + > drivers/firewire/core-transaction.c | 28 ++++++++++++++++++++++++++++ > drivers/firewire/core.h | 2 ++ > drivers/firewire/ohci.c | 5 ----- > 4 files changed, 31 insertions(+), 5 deletions(-) Applied to for-next branch. Regards Takashi Sakamoto