All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Peter Shkenev <mustela@erminea.space>
Cc: yocto-patches@lists.yoctoproject.org
Subject: Re: [meta-rockchip] [PATCH v3] rk3288: use u-boot.img as bootloader image
Date: Fri, 14 Nov 2025 10:01:14 -0500	[thread overview]
Message-ID: <20251114150114.GA26364@localhost> (raw)
In-Reply-To: <20251114145308.GA22027@localhost>

On Fri 2025-11-14 @ 09:53:08 AM, Trevor Woerner wrote:
> My build testing shows that this patch fails for the rock2-square
> MACHINE. Are others seeing this as well? In the v1 patch Quentin noticed
> this and mentioned building for all rk3288 devices, was this tested?

Actually, never mind, the fix is so small and obvious, I'll just roll it
into the patch and commit it.

> On Sun 2025-11-09 @ 01:56:41 AM, Peter Shkenev wrote:
> > Currently, u-boot.bin is used for supported rk3288-based boards. But on
> > some boards, such as tinker-board, it can not be loaded, since
> > u-boot.bin is raw and those boards have raw image support
> > (CONFIG_SPL_RAW_IMAGE_SUPPORT) disabled in favour of FIT images.
> > 
> > Use u-boot.img which is FIT when FIT support is enabled, and raw
> > otherwise.
> > 
> > Also add a note that u-boot.itb should be used if one wantes to utilize
> > OP-TEE.
> > 
> > Suggested-by: Quentin Schulz <quentin.schulz@cherry.de>
> > 
> > Signed-off-by: Peter Shkenev <mustela@erminea.space>
> > ---
> >  conf/machine/include/rk3288.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/conf/machine/include/rk3288.inc b/conf/machine/include/rk3288.inc
> > index a648b44..00cc04b 100644
> > --- a/conf/machine/include/rk3288.inc
> > +++ b/conf/machine/include/rk3288.inc
> > @@ -13,6 +13,7 @@ SERIAL_CONSOLES = "115200;ttyS2"
> >  KBUILD_DEFCONFIG ?= "multi_v7_defconfig"
> >  KERNEL_FEATURES:append:rk3288 = " bsp/rockchip/remove-non-rockchip-arch-arm.scc"
> >  
> > -UBOOT_SUFFIX ?= "bin"
> > +# Set UBOOT_SUFFIX to "itb" if you are going to use OP-TEE
> > +UBOOT_SUFFIX ?= "img"
> >  
> >  ENABLE_STATELESS_VPU_GST ?= "1"
> > -- 
> > 2.51.1
> > 


  reply	other threads:[~2025-11-14 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-08 22:56 [meta-rockchip] [PATCH v3] rk3288: use u-boot.img as bootloader image Peter Shkenev
2025-11-10  9:44 ` [yocto-patches] " Quentin Schulz
2025-11-14 14:53 ` Trevor Woerner
2025-11-14 15:01   ` Trevor Woerner [this message]
2025-11-24 13:19     ` [yocto-patches] " Quentin Schulz
2025-11-14 16:00 ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114150114.GA26364@localhost \
    --to=twoerner@gmail.com \
    --cc=mustela@erminea.space \
    --cc=yocto-patches@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.