Re: [PATCH 1/2] drivers: rtc: add PCF85063 support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On Fri, Nov 14, 2025 at 04:12:47PM +0100, Michael Walle wrote:

> Add support for the Microcrystal RV8263 and compatible RTCs. The
> driver's name was taken from linux. It should work with any NXP PCF85063
> compatible RTCs. It was tested with a RV8263.
> 
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
>  drivers/rtc/Kconfig    |   8 +++
>  drivers/rtc/Makefile   |   1 +
>  drivers/rtc/pcf85063.c | 107 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 116 insertions(+)
>  create mode 100644 drivers/rtc/pcf85063.c
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index ed903999f06..2336f2e57c9 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -161,6 +161,14 @@ config RTC_MAX313XX
>  	  - Temperature sensor
>  	  - CLKOUT generation
>  
> +config RTC_PCF85063
> +	tristate "Enable PCF85063 driver"

tristate is wrong for U-Boot, only bool is meaningful (and I need to go
update checkpatch.pl to complain about this). This is I assume otherwise
checkpatch warning free and compiles on sandbox?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]