From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A7732E734 for ; Fri, 14 Nov 2025 15:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134127; cv=none; b=Q+un5LPYNJd6PH2g9ET/na2k6F33OlqEJeNfMTGp9JJXrzWhuCw6wtCUequ4TRkWpMc7jyRXC6p7n/BUTKY5AyGmoh7k9EuEe0sl97FbVcqyT5lvKTXgrj/fumpfK/U1RUQ6l49RuHM6CglkiyRpQs11MkEgZI/xDdbf10a9nsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134127; c=relaxed/simple; bh=BM70eZB9FbP/9B/6S//Ss+GV4VqUXiu6YIrLW20c0A4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ov+NNtdsyaOX2qs0BQhPOafR7AP4WIFFvA5m+UaehmJ9YGFD1m6yw39hmT4RSP0LfyiwRVe8dlD+feF9fPRBgROwyMpIDjCUund5De+T4ln4KsXbKeztlsMkEt05GBlkSca8UQ0n/ZnRVhVHKqb0n5z9ArwrNnD79EMAJ7vMo3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id EBCCD227A88; Fri, 14 Nov 2025 16:28:40 +0100 (CET) Date: Fri, 14 Nov 2025 16:28:40 +0100 From: Christoph Hellwig To: Jeff Layton Cc: Christoph Hellwig , Christian Brauner , Al Viro , David Sterba , Jan Kara , Mike Marshall , Martin Brandenburg , Carlos Maiolino , Stefan Roesch , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, gfs2@lists.linux.dev, io-uring@vger.kernel.org, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: re-enable IOCB_NOWAIT writes to files Message-ID: <20251114152840.GD30351@lst.de> References: <20251114062642.1524837-1-hch@lst.de> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Nov 14, 2025 at 09:04:58AM -0500, Jeff Layton wrote: > This all looks pretty reasonable to me. There are a few changelog and > subject line typos, but the code changes look fine. You can add: Please tell me about them so I can fix them. > As far as nfsd's usage of FMODE_NOCMTIME, it looks OK to me. That's > implemented today by the check in file_modified_flags(), which is > generic and should work across filesystems. Nothing requires file_update_time / file_modified_flags are helpers that a file system may or may not call. I've not done an audit if everyone actually uses them. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A20C9CE8D44 for ; Fri, 14 Nov 2025 15:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r4l3h2Kvp6xpdwV1rSMe90Jd3c95Fp6lee39eQVhN/k=; b=ja4gJDAiFzwR8Z y+KzxJbfw6DUlIhfsQD+8PWB8rTyPmSDQcq9HiPeHcyb0I8LchYbayoWK8Q57a0fz6WNW5aYcWbs+ Z9iqsOThPW9kD9EGCbuN+Z9Y6UAd1mrEa9TcE17RCzrWlF+rEt3lO+6Z73AhEo69+/uv7ArWHLiO5 22/kO0GK/xsshHT9sTfYProNRCqMhnGWXJyjggpQXQn0jGp37LYqioIG0/GFXzoWMV7w89+yswOLZ 4hOKlmiVzxuiD2aBF0d3nZG+yaoZQdJDuosBnb0ZXCSLZ1gx0mx9E/viraETzKFP2B6d8inI2fRZS s9YS0RbZpfipBZACew+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJvjJ-0000000CYmA-3ATy; Fri, 14 Nov 2025 15:28:53 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJvjH-0000000CYgt-15Qi for linux-mtd@lists.infradead.org; Fri, 14 Nov 2025 15:28:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id EBCCD227A88; Fri, 14 Nov 2025 16:28:40 +0100 (CET) Date: Fri, 14 Nov 2025 16:28:40 +0100 From: Christoph Hellwig To: Jeff Layton Cc: Christoph Hellwig , Christian Brauner , Al Viro , David Sterba , Jan Kara , Mike Marshall , Martin Brandenburg , Carlos Maiolino , Stefan Roesch , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, gfs2@lists.linux.dev, io-uring@vger.kernel.org, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: re-enable IOCB_NOWAIT writes to files Message-ID: <20251114152840.GD30351@lst.de> References: <20251114062642.1524837-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251114_072851_451496_B34F8786 X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, Nov 14, 2025 at 09:04:58AM -0500, Jeff Layton wrote: > This all looks pretty reasonable to me. There are a few changelog and > subject line typos, but the code changes look fine. You can add: Please tell me about them so I can fix them. > As far as nfsd's usage of FMODE_NOCMTIME, it looks OK to me. That's > implemented today by the check in file_modified_flags(), which is > generic and should work across filesystems. Nothing requires file_update_time / file_modified_flags are helpers that a file system may or may not call. I've not done an audit if everyone actually uses them. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/