All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Neal Cardwell <ncardwell@google.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] tcp: reduce tcp_comp_sack_slack_ns default value to 10 usec
Date: Fri, 14 Nov 2025 17:43:00 -0800	[thread overview]
Message-ID: <20251114174300.19e9e2a1@kernel.org> (raw)
In-Reply-To: <CANn89iLJGwBunzho9+Q1aRDgA3ihw=OrEuT3cBDiZn2QmVNkWA@mail.gmail.com>

On Fri, 14 Nov 2025 11:35:12 -0800 Eric Dumazet wrote:
> > Makes sense, or expedite/force the IPI if these skbs are 'deferred'
> >
> > I did not complete the series to call skb_data_unref() from
> > skb_attempt_defer_free().
> > I hope to finish this soon.
> 
> In the meantime we could add this  fix:
> 
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index f34372666e67cee5329d3ba1d3c86f8622facac3..12d65357fc7f83cfa9f8714227c7b69035441644
> 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -1480,6 +1480,9 @@ void napi_consume_skb(struct sk_buff *skb, int budget)
>         DEBUG_NET_WARN_ON_ONCE(!in_softirq());
> 
>         if (skb->alloc_cpu != smp_processor_id() && !skb_shared(skb)) {
> +               if (skb_zcopy(skb))
> +                       return consume_skb(skb);
> +
>                 skb_release_head_state(skb);
>                 return skb_attempt_defer_free(skb);
>         }

Queued locally in the CI for now.

  reply	other threads:[~2025-11-15  1:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 13:51 [PATCH net] tcp: reduce tcp_comp_sack_slack_ns default value to 10 usec Eric Dumazet
2025-11-14 14:08 ` Eric Dumazet
2025-11-14 16:03   ` Jakub Kicinski
2025-11-14 16:17     ` Eric Dumazet
2025-11-14 19:35       ` Eric Dumazet
2025-11-15  1:43         ` Jakub Kicinski [this message]
2025-11-14 14:22 ` Neal Cardwell
2025-11-18  1:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114174300.19e9e2a1@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuniyu@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.