All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Loïc Molinari" <loic.molinari@collabora.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Rob Herring" <robh@kernel.org>,
	"Steven Price" <steven.price@arm.com>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Melissa Wen" <mwen@igalia.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Hugh Dickins" <hughd@google.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Mikołaj Wasiak" <mikolaj.wasiak@intel.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Nitin Gote" <nitin.r.gote@intel.com>,
	"Andi Shyti" <andi.shyti@linux.intel.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Christopher Healy" <healych@amazon.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v9 07/11] drm/gem: Get rid of *_with_mnt helpers
Date: Fri, 14 Nov 2025 18:15:40 +0100	[thread overview]
Message-ID: <20251114181540.102789b1@fedora> (raw)
In-Reply-To: <20251114170303.2800-8-loic.molinari@collabora.com>

On Fri, 14 Nov 2025 18:02:58 +0100
Loïc Molinari <loic.molinari@collabora.com> wrote:

> diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c
> index 211578abf9b6..c4316b768b3d 100644
> --- a/drivers/gpu/drm/v3d/v3d_bo.c
> +++ b/drivers/gpu/drm/v3d/v3d_bo.c
> @@ -153,12 +153,7 @@ struct v3d_bo *v3d_bo_create(struct drm_device *dev, struct drm_file *file_priv,
>  	struct v3d_bo *bo;
>  	int ret;
>  
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> -	shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size,
> -						  dev->huge_mnt);
> -#else
>  	shmem_obj = drm_gem_shmem_create(dev, unaligned_size);
> -#endif

Hm, okay, the thing I complained about in patch 6 is dropped here. If
there's nothing else to address, don't bother sending a new version
just for that.

>  	if (IS_ERR(shmem_obj))
>  		return ERR_CAST(shmem_obj);
>  	bo = to_v3d_bo(&shmem_obj->base);

  reply	other threads:[~2025-11-14 17:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 17:02 [PATCH v9 00/11] drm: Reduce page tables overhead with THP Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 01/11] drm/shmem-helper: Simplify page offset calculation in fault handler Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 02/11] drm/shmem-helper: Map huge pages " Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 03/11] drm/gem: Introduce drm_gem_get_unmapped_area() fop Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 04/11] drm/gem: Add huge tmpfs mountpoint helpers Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 05/11] drm/i915: Use " Loïc Molinari
2025-11-20  9:31   ` Tvrtko Ursulin
2025-11-28 18:41     ` Loïc Molinari
2025-12-02 11:01       ` Tvrtko Ursulin
2025-12-05  8:37         ` Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 06/11] drm/v3d: " Loïc Molinari
2025-11-14 17:11   ` Boris Brezillon
2025-11-14 17:21     ` Loïc Molinari
2025-11-20  9:39   ` Tvrtko Ursulin
2025-11-28 18:19     ` Loïc Molinari
2025-11-14 17:02 ` [PATCH v9 07/11] drm/gem: Get rid of *_with_mnt helpers Loïc Molinari
2025-11-14 17:15   ` Boris Brezillon [this message]
2025-11-14 17:02 ` [PATCH v9 08/11] drm/panthor: Introduce huge tmpfs mountpoint option Loïc Molinari
2025-11-14 17:03 ` [PATCH v9 09/11] drm/panthor: Improve IOMMU map/unmap debugging logs Loïc Molinari
2025-11-26 10:10   ` Boris Brezillon
2025-11-14 17:03 ` [PATCH v9 10/11] drm/panfrost: Introduce huge tmpfs mountpoint option Loïc Molinari
2025-11-14 17:03 ` [PATCH v9 11/11] Documentation/gpu/drm-mm: Add THP paragraph to GEM mapping section Loïc Molinari
2025-11-15  9:53 ` ✗ i915.CI.Full: failure for drm: Reduce page tables overhead with THP (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114181540.102789b1@fedora \
    --to=boris.brezillon@collabora.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=bagasdotme@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=healych@amazon.com \
    --cc=hughd@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kernel@collabora.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liviu.dudau@arm.com \
    --cc=loic.molinari@collabora.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=mikolaj.wasiak@intel.com \
    --cc=mripard@kernel.org \
    --cc=mwen@igalia.com \
    --cc=nitin.r.gote@intel.com \
    --cc=robh@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.