diff for duplicates of <202511151216.rhK2ItOb-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 0925765..020a12d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,18 +1,58 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +In-Reply-To: <20251114012228.2634882-1-balbirs@nvidia.com> +References: <20251114012228.2634882-1-balbirs@nvidia.com> +TO: Balbir Singh <balbirs@nvidia.com> +TO: linux-kernel@vger.kernel.org +TO: linux-mm@kvack.org +TO: dri-devel@lists.freedesktop.org +CC: Balbir Singh <balbirs@nvidia.com> +CC: Andrew Morton <akpm@linux-foundation.org> +CC: Linux Memory Management List <linux-mm@kvack.org> +CC: David Hildenbrand <david@redhat.com> +CC: Zi Yan <ziy@nvidia.com> +CC: Joshua Hahn <joshua.hahnjy@gmail.com> +CC: Rakie Kim <rakie.kim@sk.com> +CC: Byungchul Park <byungchul@sk.com> +CC: Gregory Price <gourry@gourry.net> +CC: Ying Huang <ying.huang@linux.alibaba.com> +CC: Alistair Popple <apopple@nvidia.com> +CC: Oscar Salvador <osalvador@suse.de> +CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> +CC: Baolin Wang <baolin.wang@linux.alibaba.com> +CC: "Liam R. Howlett" <Liam.Howlett@oracle.com> +CC: Nico Pache <npache@redhat.com> +CC: Ryan Roberts <ryan.roberts@arm.com> +CC: Dev Jain <dev.jain@arm.com> +CC: Barry Song <baohua@kernel.org> +CC: Lyude Paul <lyude@redhat.com> +CC: Danilo Krummrich <dakr@kernel.org> +CC: David Airlie <airlied@gmail.com> +CC: Simona Vetter <simona@ffwll.ch> +CC: Ralph Campbell <rcampbell@nvidia.com> +CC: "Mika Penttilä" <mpenttil@redhat.com> +CC: Matthew Brost <matthew.brost@intel.com> +CC: Francois Dugast <francois.dugast@intel.com> + Hi Balbir, kernel test robot noticed the following build warnings: +[auto build test WARNING on akpm-mm/mm-everything] + url: https://github.com/intel-lab-lkp/linux/commits/Balbir-Singh/mm-huge_memory-c-introduce-folio_split_unmapped/20251114-093541 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20251114012228.2634882-1-balbirs%40nvidia.com patch subject: [PATCH] mm/huge_memory.c: introduce folio_split_unmapped +:::::: branch date: 27 hours ago +:::::: commit date: 27 hours ago config: i386-randconfig-141-20251115 (https://download.01.org/0day-ci/archive/20251115/202511151216.rhK2ItOb-lkp@intel.com/config) compiler: gcc-12 (Debian 12.4.0-5) 12.4.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202511151216.rhK2ItOb-lkp@intel.com/ smatch warnings: @@ -21,6 +61,28 @@ mm/huge_memory.c:4052 __folio_split() error: we previously assumed 'mapping' cou vim +/end +4044 mm/huge_memory.c +f6b1f167ffe29f Balbir Singh 2025-11-14 3886 +aeb1f4fbd83085 Zi Yan 2025-10-31 3887 /** +aeb1f4fbd83085 Zi Yan 2025-10-31 3888 * __folio_split() - split a folio at @split_at to a @new_order folio +58729c04cf1092 Zi Yan 2025-03-07 3889 * @folio: folio to split +58729c04cf1092 Zi Yan 2025-03-07 3890 * @new_order: the order of the new folio +58729c04cf1092 Zi Yan 2025-03-07 3891 * @split_at: a page within the new folio +58729c04cf1092 Zi Yan 2025-03-07 3892 * @lock_at: a page within @folio to be left locked to caller +58729c04cf1092 Zi Yan 2025-03-07 3893 * @list: after-split folios will be put on it if non NULL +3c844d850e4486 Wei Yang 2025-11-06 3894 * @split_type: perform uniform split or not (non-uniform split) +58729c04cf1092 Zi Yan 2025-03-07 3895 * +58729c04cf1092 Zi Yan 2025-03-07 3896 * It calls __split_unmapped_folio() to perform uniform and non-uniform split. +58729c04cf1092 Zi Yan 2025-03-07 3897 * It is in charge of checking whether the split is supported or not and +58729c04cf1092 Zi Yan 2025-03-07 3898 * preparing @folio for __split_unmapped_folio(). +58729c04cf1092 Zi Yan 2025-03-07 3899 * +6c7de9c83be68b Zi Yan 2025-07-18 3900 * After splitting, the after-split folio containing @lock_at remains locked +6c7de9c83be68b Zi Yan 2025-07-18 3901 * and others are unlocked: +6c7de9c83be68b Zi Yan 2025-07-18 3902 * 1. for uniform split, @lock_at points to one of @folio's subpages; +6c7de9c83be68b Zi Yan 2025-07-18 3903 * 2. for buddy allocator like (non-uniform) split, @lock_at points to @folio. +6c7de9c83be68b Zi Yan 2025-07-18 3904 * +aeb1f4fbd83085 Zi Yan 2025-10-31 3905 * Return: 0 - successful, <0 - failed (if -ENOMEM is returned, @folio might be +58729c04cf1092 Zi Yan 2025-03-07 3906 * split but not to @new_order, the caller needs to check) +58729c04cf1092 Zi Yan 2025-03-07 3907 */ 6384dd1d18de7b Zi Yan 2025-03-07 3908 static int __folio_split(struct folio *folio, unsigned int new_order, 58729c04cf1092 Zi Yan 2025-03-07 3909 struct page *split_at, struct page *lock_at, f6b1f167ffe29f Balbir Singh 2025-11-14 3910 struct list_head *list, enum split_type split_type) @@ -75,9 +137,6 @@ e9b61f19858a5d Kirill A. Shutemov 2016-01-15 3958 goto out; e9b61f19858a5d Kirill A. Shutemov 2016-01-15 3959 } e9b61f19858a5d Kirill A. Shutemov 2016-01-15 3960 anon_vma_lock_write(anon_vma); 3d4c0d98eb8572 Balbir Singh 2025-10-01 3961 mapping = NULL; - -end is not initialized for anonymous folios. - baa355fd331424 Kirill A. Shutemov 2016-07-26 3962 } else { e220917fa50774 Luis Chamberlain 2024-08-22 3963 unsigned int min_order; 6a3edd29395631 Yin Fengwei 2022-08-10 3964 gfp_t gfp; @@ -161,10 +220,6 @@ baa355fd331424 Kirill A. Shutemov 2016-07-26 4040 } baa355fd331424 Kirill A. Shutemov 2016-07-26 4042 f6b1f167ffe29f Balbir Singh 2025-11-14 4043 ret = __folio_freeze_and_split_unmapped(folio, new_order, split_at, &xas, mapping, f6b1f167ffe29f Balbir Singh 2025-11-14 @4044 true, list, split_type, end, extra_pins); - ^^^ -Passing uninitialized variables isn't allowed unless the function is -inlined. It triggers a UBSan warning at runtime as well. - 391dc7f40590d7 Zi Yan 2025-07-18 4045 fail: 6c7de9c83be68b Zi Yan 2025-07-18 @4046 if (mapping) 6c7de9c83be68b Zi Yan 2025-07-18 4047 xas_unlock(&xas); @@ -173,10 +228,6 @@ inlined. It triggers a UBSan warning at runtime as well. 6c7de9c83be68b Zi Yan 2025-07-18 4050 391dc7f40590d7 Zi Yan 2025-07-18 4051 if (nr_shmem_dropped) 391dc7f40590d7 Zi Yan 2025-07-18 @4052 shmem_uncharge(mapping->host, nr_shmem_dropped); - -Smatch complains that mapping can be NULL, but this is false positive -because nr_shmem_dropped is always zero. - 6c7de9c83be68b Zi Yan 2025-07-18 4053 958fea4c1e2eb6 Balbir Singh 2025-10-01 4054 if (!ret && is_anon && !folio_is_device_private(folio)) 391dc7f40590d7 Zi Yan 2025-07-18 4055 remap_flags = RMP_USE_SHARED_ZEROPAGE; @@ -217,6 +268,7 @@ e9b61f19858a5d Kirill A. Shutemov 2016-01-15 4089 count_vm_event(!ret ? 8ec26327c18e1d Wei Yang 2025-10-10 4090 count_mthp_stat(old_order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED); e9b61f19858a5d Kirill A. Shutemov 2016-01-15 4091 return ret; e9b61f19858a5d Kirill A. Shutemov 2016-01-15 4092 } +9a982250f773cc Kirill A. Shutemov 2016-01-15 4093 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index f2ad2b9..cc99ef5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,58 +1,66 @@ - "ref\020251114012228.2634882-1-balbirs@nvidia.com\0" - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH] mm/huge_memory.c: introduce folio_split_unmapped\0" - "Date\0Wed, 19 Nov 2025 15:32:57 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - Balbir Singh <balbirs@nvidia.com> - linux-kernel@vger.kernel.org - linux-mm@kvack.org - " dri-devel@lists.freedesktop.org\0" + "Date\0Sat, 15 Nov 2025 13:09:39 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - Balbir Singh <balbirs@nvidia.com> - Andrew Morton <akpm@linux-foundation.org> - Linux Memory Management List <linux-mm@kvack.org> - David Hildenbrand <david@redhat.com> - Zi Yan <ziy@nvidia.com> - Joshua Hahn <joshua.hahnjy@gmail.com> - Rakie Kim <rakie.kim@sk.com> - Byungchul Park <byungchul@sk.com> - Gregory Price <gourry@gourry.net> - Ying Huang <ying.huang@linux.alibaba.com> - Alistair Popple <apopple@nvidia.com> - Oscar Salvador <osalvador@suse.de> - Lorenzo Stoakes <lorenzo.stoakes@oracle.com> - Baolin Wang <baolin.wang@linux.alibaba.com> - Liam R. Howlett <Liam.Howlett@oracle.com> - Nico Pache <npache@redhat.com> - Ryan Roberts <ryan.roberts@arm.com> - Dev Jain <dev.jain@arm.com> - Barry Song <baohua@kernel.org> - Lyude Paul <lyude@redhat.com> - Danilo Krummrich <dakr@kernel.org> - David Airlie <airlied@gmail.com> - Simona Vetter <simona@ffwll.ch> - Ralph Campbell <rcampbell@nvidia.com> - " Mika Penttil\303\244 <mpenttil@redhat.com>" - Matthew Brost <matthew.brost@intel.com> - " Francois Dugast <francois.dugast@intel.com>\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "In-Reply-To: <20251114012228.2634882-1-balbirs@nvidia.com>\n" + "References: <20251114012228.2634882-1-balbirs@nvidia.com>\n" + "TO: Balbir Singh <balbirs@nvidia.com>\n" + "TO: linux-kernel@vger.kernel.org\n" + "TO: linux-mm@kvack.org\n" + "TO: dri-devel@lists.freedesktop.org\n" + "CC: Balbir Singh <balbirs@nvidia.com>\n" + "CC: Andrew Morton <akpm@linux-foundation.org>\n" + "CC: Linux Memory Management List <linux-mm@kvack.org>\n" + "CC: David Hildenbrand <david@redhat.com>\n" + "CC: Zi Yan <ziy@nvidia.com>\n" + "CC: Joshua Hahn <joshua.hahnjy@gmail.com>\n" + "CC: Rakie Kim <rakie.kim@sk.com>\n" + "CC: Byungchul Park <byungchul@sk.com>\n" + "CC: Gregory Price <gourry@gourry.net>\n" + "CC: Ying Huang <ying.huang@linux.alibaba.com>\n" + "CC: Alistair Popple <apopple@nvidia.com>\n" + "CC: Oscar Salvador <osalvador@suse.de>\n" + "CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>\n" + "CC: Baolin Wang <baolin.wang@linux.alibaba.com>\n" + "CC: \"Liam R. Howlett\" <Liam.Howlett@oracle.com>\n" + "CC: Nico Pache <npache@redhat.com>\n" + "CC: Ryan Roberts <ryan.roberts@arm.com>\n" + "CC: Dev Jain <dev.jain@arm.com>\n" + "CC: Barry Song <baohua@kernel.org>\n" + "CC: Lyude Paul <lyude@redhat.com>\n" + "CC: Danilo Krummrich <dakr@kernel.org>\n" + "CC: David Airlie <airlied@gmail.com>\n" + "CC: Simona Vetter <simona@ffwll.ch>\n" + "CC: Ralph Campbell <rcampbell@nvidia.com>\n" + "CC: \"Mika Penttil\303\244\" <mpenttil@redhat.com>\n" + "CC: Matthew Brost <matthew.brost@intel.com>\n" + "CC: Francois Dugast <francois.dugast@intel.com>\n" + "\n" "Hi Balbir,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" + "[auto build test WARNING on akpm-mm/mm-everything]\n" + "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Balbir-Singh/mm-huge_memory-c-introduce-folio_split_unmapped/20251114-093541\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything\n" "patch link: https://lore.kernel.org/r/20251114012228.2634882-1-balbirs%40nvidia.com\n" "patch subject: [PATCH] mm/huge_memory.c: introduce folio_split_unmapped\n" + ":::::: branch date: 27 hours ago\n" + ":::::: commit date: 27 hours ago\n" "config: i386-randconfig-141-20251115 (https://download.01.org/0day-ci/archive/20251115/202511151216.rhK2ItOb-lkp@intel.com/config)\n" "compiler: gcc-12 (Debian 12.4.0-5) 12.4.0\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202511151216.rhK2ItOb-lkp@intel.com/\n" "\n" "smatch warnings:\n" @@ -61,6 +69,28 @@ "\n" "vim +/end +4044 mm/huge_memory.c\n" "\n" + "f6b1f167ffe29f Balbir Singh 2025-11-14 3886 \n" + "aeb1f4fbd83085 Zi Yan 2025-10-31 3887 /**\n" + "aeb1f4fbd83085 Zi Yan 2025-10-31 3888 * __folio_split() - split a folio at @split_at to a @new_order folio\n" + "58729c04cf1092 Zi Yan 2025-03-07 3889 * @folio: folio to split\n" + "58729c04cf1092 Zi Yan 2025-03-07 3890 * @new_order: the order of the new folio\n" + "58729c04cf1092 Zi Yan 2025-03-07 3891 * @split_at: a page within the new folio\n" + "58729c04cf1092 Zi Yan 2025-03-07 3892 * @lock_at: a page within @folio to be left locked to caller\n" + "58729c04cf1092 Zi Yan 2025-03-07 3893 * @list: after-split folios will be put on it if non NULL\n" + "3c844d850e4486 Wei Yang 2025-11-06 3894 * @split_type: perform uniform split or not (non-uniform split)\n" + "58729c04cf1092 Zi Yan 2025-03-07 3895 *\n" + "58729c04cf1092 Zi Yan 2025-03-07 3896 * It calls __split_unmapped_folio() to perform uniform and non-uniform split.\n" + "58729c04cf1092 Zi Yan 2025-03-07 3897 * It is in charge of checking whether the split is supported or not and\n" + "58729c04cf1092 Zi Yan 2025-03-07 3898 * preparing @folio for __split_unmapped_folio().\n" + "58729c04cf1092 Zi Yan 2025-03-07 3899 *\n" + "6c7de9c83be68b Zi Yan 2025-07-18 3900 * After splitting, the after-split folio containing @lock_at remains locked\n" + "6c7de9c83be68b Zi Yan 2025-07-18 3901 * and others are unlocked:\n" + "6c7de9c83be68b Zi Yan 2025-07-18 3902 * 1. for uniform split, @lock_at points to one of @folio's subpages;\n" + "6c7de9c83be68b Zi Yan 2025-07-18 3903 * 2. for buddy allocator like (non-uniform) split, @lock_at points to @folio.\n" + "6c7de9c83be68b Zi Yan 2025-07-18 3904 *\n" + "aeb1f4fbd83085 Zi Yan 2025-10-31 3905 * Return: 0 - successful, <0 - failed (if -ENOMEM is returned, @folio might be\n" + "58729c04cf1092 Zi Yan 2025-03-07 3906 * split but not to @new_order, the caller needs to check)\n" + "58729c04cf1092 Zi Yan 2025-03-07 3907 */\n" "6384dd1d18de7b Zi Yan 2025-03-07 3908 static int __folio_split(struct folio *folio, unsigned int new_order,\n" "58729c04cf1092 Zi Yan 2025-03-07 3909 \t\tstruct page *split_at, struct page *lock_at,\n" "f6b1f167ffe29f Balbir Singh 2025-11-14 3910 \t\tstruct list_head *list, enum split_type split_type)\n" @@ -115,9 +145,6 @@ "e9b61f19858a5d Kirill A. Shutemov 2016-01-15 3959 \t\t}\n" "e9b61f19858a5d Kirill A. Shutemov 2016-01-15 3960 \t\tanon_vma_lock_write(anon_vma);\n" "3d4c0d98eb8572 Balbir Singh 2025-10-01 3961 \t\tmapping = NULL;\n" - "\n" - "end is not initialized for anonymous folios.\n" - "\n" "baa355fd331424 Kirill A. Shutemov 2016-07-26 3962 \t} else {\n" "e220917fa50774 Luis Chamberlain 2024-08-22 3963 \t\tunsigned int min_order;\n" "6a3edd29395631 Yin Fengwei 2022-08-10 3964 \t\tgfp_t gfp;\n" @@ -201,10 +228,6 @@ "baa355fd331424 Kirill A. Shutemov 2016-07-26 4042 \n" "f6b1f167ffe29f Balbir Singh 2025-11-14 4043 \tret = __folio_freeze_and_split_unmapped(folio, new_order, split_at, &xas, mapping,\n" "f6b1f167ffe29f Balbir Singh 2025-11-14 @4044 \t\t\t\t\t\ttrue, list, split_type, end, extra_pins);\n" - " ^^^\n" - "Passing uninitialized variables isn't allowed unless the function is\n" - "inlined. It triggers a UBSan warning at runtime as well.\n" - "\n" "391dc7f40590d7 Zi Yan 2025-07-18 4045 fail:\n" "6c7de9c83be68b Zi Yan 2025-07-18 @4046 \tif (mapping)\n" "6c7de9c83be68b Zi Yan 2025-07-18 4047 \t\txas_unlock(&xas);\n" @@ -213,10 +236,6 @@ "6c7de9c83be68b Zi Yan 2025-07-18 4050 \n" "391dc7f40590d7 Zi Yan 2025-07-18 4051 \tif (nr_shmem_dropped)\n" "391dc7f40590d7 Zi Yan 2025-07-18 @4052 \t\tshmem_uncharge(mapping->host, nr_shmem_dropped);\n" - "\n" - "Smatch complains that mapping can be NULL, but this is false positive\n" - "because nr_shmem_dropped is always zero.\n" - "\n" "6c7de9c83be68b Zi Yan 2025-07-18 4053 \n" "958fea4c1e2eb6 Balbir Singh 2025-10-01 4054 \tif (!ret && is_anon && !folio_is_device_private(folio))\n" "391dc7f40590d7 Zi Yan 2025-07-18 4055 \t\tremap_flags = RMP_USE_SHARED_ZEROPAGE;\n" @@ -257,9 +276,10 @@ "8ec26327c18e1d Wei Yang 2025-10-10 4090 \tcount_mthp_stat(old_order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED);\n" "e9b61f19858a5d Kirill A. Shutemov 2016-01-15 4091 \treturn ret;\n" "e9b61f19858a5d Kirill A. Shutemov 2016-01-15 4092 }\n" + "9a982250f773cc Kirill A. Shutemov 2016-01-15 4093 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -21b49ae823ff29d3169601f95706ed509c7237a315ce114f9ebb4673a53ccddc +214e490fa9b81df9850cd7a81e692476a461d9569a2a432c6e610c4d0768c4bd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.