All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rene Rebe <rene@exactco.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Geoff Levand <geoff@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}_bvec index
Date: Sun, 16 Nov 2025 07:13:54 -0500	[thread overview]
Message-ID: <2025111611-spinout-blabber-0ae2@gregkh> (raw)
In-Reply-To: <20251114.153033.430439310885688884.rene@exactco.de>

On Fri, Nov 14, 2025 at 03:30:33PM +0100, Rene Rebe wrote:
> With 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) converting
> ps3disk to new bvec helpers, incrementing the offset was accidently
> lost, corrupting consecutive buffers. Restore index for non-corrupted
> data transfers.
> 
> Fixes: 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec)
> 
> Signed-off-by: René Rebe <rene@exactco.de>
> 
> --- a/drivers/block/ps3disk.c	2023-08-07 17:40:55.200957746 +0200
> +++ b/drivers/block/ps3disk.c	2023-08-07 17:46:39.702964129 +0200
> @@ -85,10 +93,14 @@
>  	struct bio_vec bvec;
>  
>  	rq_for_each_segment(bvec, req, iter) {
> +		dev_dbg(&dev->sbd.core, "%s:%u: %u sectors from %llu\n",
> +			__func__, __LINE__, bio_sectors(iter.bio),

In the future, please note that all dev_dbg() calls have __func__ built
into them, and I think __LINE__ as well, so there's no need to ever add
that to the output.  Take a look at the documentation for more details
on how to see that in the log.

thanks,

greg k-h

  parent reply	other threads:[~2025-11-16 12:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 14:30 [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}_bvec index Rene Rebe
2025-11-14 15:25 ` Christoph Hellwig
2025-11-14 16:11 ` Jens Axboe
2025-11-16 12:13 ` Greg Kroah-Hartman [this message]
2025-11-17  9:47   ` Geert Uytterhoeven
2025-11-17 10:16     ` René Rebe
2025-11-17 12:39     ` Greg Kroah-Hartman
2025-11-17 13:05       ` Geert Uytterhoeven
2025-11-17 13:13         ` Greg Kroah-Hartman
2025-11-17 13:31           ` Geert Uytterhoeven
2025-11-18  2:36             ` Greg Kroah-Hartman
2025-11-18  7:46               ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025111611-spinout-blabber-0ae2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=geoff@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rene@exactco.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.