From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1EE2D46D0 for ; Sun, 16 Nov 2025 12:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763296219; cv=none; b=R9PpDEiihdXNBMpw4x5wYxtyFgcEyoi3VYbfnRHRNLlSP16sQ0OwAgMAb/i4IhlFDymfXt6MI0v1JKGEDBeDNeCc4Lzbzwm5J4eF6ETGlXI+xHsx+lNyi8IerqqxBWFsXpJsNtkf7WiK2JYsXLuHJ4Nx9dq8WMmtlRJ3wF3tAlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763296219; c=relaxed/simple; bh=sgDMGxFt1AU0d5AlnOl1ibB3IS+puGLc33AW3Pe4TY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bV91m1c7PU7T2rBqAAPI63IPZ9nqE0g1wTKit0wqrz8X785jZMaoVUGNgbOg6vAWBGlw+F7dXR81RHLsRIfafRU+HI8aZSVhMD7vvBRz40UXOJ67tLyHiKssr7/V24lxWH5IbBaZqWV9Z6EGKahIGtHd2eJU+jUhE2sGDMrlYYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=d71c5kLK; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=2aLXubQ9; arc=none smtp.client-ip=202.12.124.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="d71c5kLK"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="2aLXubQ9" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id C38F71D000BF; Sun, 16 Nov 2025 07:30:14 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sun, 16 Nov 2025 07:30:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1763296214; x= 1763382614; bh=uxC9pM3cZF/CjUUd1dvay5FUET9Y6MOVQLwFNe+GFAY=; b=d 71c5kLKuEhqG1gE2TJSYIImx9P11ZtAVlo20BO3pfS24X7tHoncIkknDEKC+3nnv 4ZYjaB718Vfy+wukph+/oqCUz93hPj5vVdbib/UlZOkytN4nIAHXM6cJrUYZmc4T 3fLI7Br78T9AIygOy6aapSsuLA87PvYimbMHl4CJn2RxcoeTI4sIjisUx2rroRk6 W+SLXCAUhxct7Ib8XdZAHaYdC2xexyee/j/nmNGBsr68jpL+ozXNV3n5bDTQCyqB vaaHvwgOflb4rGPDhIHqwaXmq7e8+fjUT4Sk2pATxIterk4TBj2z5bNnUw4boa+Y 9WR+WvePg4CD/2Ibv4jWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1763296214; x=1763382614; bh=uxC9pM3cZF/CjUUd1dvay5FUET9Y6MOVQLw FNe+GFAY=; b=2aLXubQ9t5dcyv9zdR7ZDhg4mGNwuRZzor28CIRYCFvRaQNMMQU W5q98hMfoXwpE9Ooujr9Fm22I7URHHIvwM1v3y7XC6SEziI69YtS1lgiI55dTk48 JuSJzUP9tv1M8G0fA/JeKahYVaNLZX0QlUh7KIBw5qyVUk5y+p0EPPAgdojGoYjL R2g6RS5mecbzoTrrBlXxvzf1wj9ShTUThhjv9kBW6c5ti2wBxroCOMMRjzFUHehV AqzeYH6ZQbLhiONi+xlwzhlqWrrYU6ByoPQumEQHQPM7sPJmvg4xcy+Z8VRreXbF jOJl7nZFErqUcCWWMTiYAngQ7SefILDKT/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvudehheelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttdertd dttddvnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpeehhffhteetgf ekvdeiueffveevueeftdelhfejieeitedvleeftdfgfeeuudekueenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Nov 2025 07:30:13 -0500 (EST) Date: Sun, 16 Nov 2025 21:30:11 +0900 From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: core: fix to update generation field in topology map Message-ID: <20251116123011.GA646745@workstation.local> Mail-Followup-To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20251114144421.415278-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251114144421.415278-1-o-takashi@sakamocchi.jp> On Fri, Nov 14, 2025 at 11:44:21PM +0900, Takashi Sakamoto wrote: > The generation field of topology map is updated after initialized by zero. > The updated value of generation field is always zero, and is against > specification. > > This commit fixes the bug. > > Fixes: 7d138cb269db ("firewire: core: use spin lock specific to topology map") > Signed-off-by: Takashi Sakamoto > --- > drivers/firewire/core-topology.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to for-linus branch. Regards Takashi Sakamoto