From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDFD3346A6 for ; Mon, 17 Nov 2025 12:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763383196; cv=none; b=bnqwxWoz47l6sN9ISHGCn63sFKhRaZXuoiDRWt9IaVuFyUFsKvmxV8RRRJ3YBTVh1jX6cE5UiJql/Fq4P/1EDjr6gFdOofbuG1Lo9Iru+uk5QJJHa/xxlYa9p2bT91KyXm1OGs3RL+M+XnpJxu3Y0oi5/HmzYAGjWWlrp4EfBVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763383196; c=relaxed/simple; bh=kRpliErg25gO3AER/ZJVWSQyDRmlnHWROEMfk6oVAcg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GE+uNS1yRv03a+KJ45p6AXOFEVRZFlmDF0RsUThZfSGZSROdOzqp1nmTVjAneWS42RrEyBFWah6wi4FB0odymdaL667BIdIWPVhWOUOO3dzRjEEje8cx+N5zkb1PEnMUm+3qR/E6MDJ3XVV0gpBCEzmHU9YFR7JUr8tzY7iZ8qY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EofxdpeE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EofxdpeE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F501C19422; Mon, 17 Nov 2025 12:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763383195; bh=kRpliErg25gO3AER/ZJVWSQyDRmlnHWROEMfk6oVAcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EofxdpeEm6nd/HF4gV/TimpQDbyc+klQ7qOWiKcz7FXIH1QLrgusO8Uc8W7OaP6Hb MYUw1Kqb9Utiv3/RxgNh6rvdxtFxNt/hKEDixWZde/cPeARD5hujep+TBOMSxcKzRA Yq7vo2tZQaZoC8BocJrPLV5tlM1De9zSLFS6aKfw= Date: Mon, 17 Nov 2025 07:39:52 -0500 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Rene Rebe , Christoph Hellwig , Jens Axboe , "Martin K. Petersen" , Geoff Levand , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}_bvec index Message-ID: <2025111700-charbroil-freeness-d53d@gregkh> References: <20251114.153033.430439310885688884.rene@exactco.de> <2025111611-spinout-blabber-0ae2@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Nov 17, 2025 at 10:47:49AM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Sun, 16 Nov 2025 at 13:14, Greg Kroah-Hartman > wrote: > > On Fri, Nov 14, 2025 at 03:30:33PM +0100, Rene Rebe wrote: > > > With 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) converting > > > ps3disk to new bvec helpers, incrementing the offset was accidently > > > lost, corrupting consecutive buffers. Restore index for non-corrupted > > > data transfers. > > > > > > Fixes: 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) > > > > > > Signed-off-by: René Rebe > > > > > > --- a/drivers/block/ps3disk.c 2023-08-07 17:40:55.200957746 +0200 > > > +++ b/drivers/block/ps3disk.c 2023-08-07 17:46:39.702964129 +0200 > > > @@ -85,10 +93,14 @@ > > > struct bio_vec bvec; > > > > > > rq_for_each_segment(bvec, req, iter) { > > > + dev_dbg(&dev->sbd.core, "%s:%u: %u sectors from %llu\n", > > > + __func__, __LINE__, bio_sectors(iter.bio), > > > > In the future, please note that all dev_dbg() calls have __func__ built > > into them, and I think __LINE__ as well, so there's no need to ever add > > that to the output. Take a look at the documentation for more details > > on how to see that in the log. > > That does not seem to be true in v6.18-rc6: the function name and line > number are not included. What changed to remove them? Look at Documentation/admin-guide/dynamic-debug-howto.rst for how to enable both of these for any dynamic debug message in the kernel. Does that not work properly here? thanks, greg k-h