From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2FAC26E719 for ; Mon, 17 Nov 2025 09:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763371930; cv=none; b=E3oLJ4/6nrmsMqbKrWPBo4gKauD4gWtYd5UcZd1XtmljqKwYu2ot6f7oYPMmkP5TJwuUzIHUKF5+hOxaHTpYs/tkBTrM5YyuLjlkVlXH4qZh8iGKPWDiT11cI+s481dOSt2SxLB6LuJ6jSIs2tiYrY1OzONU7R3cSgK07JQS4B4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763371930; c=relaxed/simple; bh=PGoHYW7B8+LDVwFtVRdXwPEpjJQ4sP/rAno4JbW6oXk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UWR2X66rTBEayXWgva+RNXLmyjaTmlBBQhNp0M3j9SVLusnjV1FND1B4a0CwYWut0HoKwgv2jxwcxLNSOSisCJonz7T0lxHtLCTVZuIUGsnJG13ivz/zxzc78brl6Qs5E/h+2TcX+PrBI+jcAYYSwQk5x4Co+vl8TDkImF4VvLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EWuIPJL1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EWuIPJL1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8446BC113D0; Mon, 17 Nov 2025 09:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763371929; bh=PGoHYW7B8+LDVwFtVRdXwPEpjJQ4sP/rAno4JbW6oXk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EWuIPJL1bqRIH7p41nMmr+K1cmJpvPwfeBJoqlZmiAuAqbw957x+oC6OaO/XFgtKF JT5D9JupA8Gz5Vxo6dnQtUtl3NQ17cPExZbeUmPu/e69LbNDfwYfk9dVuYXf42TZn2 hKqHOuhRXF+BR24bMyZjUFj2xtH4pR81n+DXYLvYXxBlCB4aFJSc4OzsKR2YkjVm0s jvUA7ouyvjN63asGKpgmzafRqO4w0pXKCoNDH9vncIyX1rX4NW9oKarfirPQ02LYSX XO27BxiKwkYLBF34s7ZiFczX/TvBidA0vsqFv+TG+XxH5x3NzIEiLhrIngrl+FeNer GNOQWsJr/gzqg== From: Jiri Olsa To: Thomas Gleixner , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , Borislav Petkov , Dave Hansen Subject: [PATCH 2/5] x86/insn-eval: Remove regs arg from get_reg_offset Date: Mon, 17 Nov 2025 10:31:34 +0100 Message-ID: <20251117093137.572132-3-jolsa@kernel.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org> References: <20251117093137.572132-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It's not used, get_reg_offset returns only offset to struct pt_regs, not the actual register values. Signed-off-by: Jiri Olsa --- arch/x86/lib/insn-eval.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 7b46eb717066..8b9c2b90d66e 100644 --- a/arch/x86/lib/insn-eval.c +++ b/arch/x86/lib/insn-eval.c @@ -519,8 +519,7 @@ static int get_regno(struct insn *insn, enum reg_type type) return regno; } -static int get_reg_offset(struct insn *insn, struct pt_regs *regs, - enum reg_type type) +static int get_reg_offset(struct insn *insn, enum reg_type type) { int regno = get_regno(insn, type); @@ -861,7 +860,7 @@ int insn_get_code_seg_params(struct pt_regs *regs) */ int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs) { - return get_reg_offset(insn, regs, REG_TYPE_RM); + return get_reg_offset(insn, REG_TYPE_RM); } /** @@ -876,7 +875,7 @@ int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs) */ int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs) { - return get_reg_offset(insn, regs, REG_TYPE_REG); + return get_reg_offset(insn, REG_TYPE_REG); } /** @@ -982,7 +981,7 @@ static int get_eff_addr_reg(struct insn *insn, struct pt_regs *regs, if (X86_MODRM_MOD(insn->modrm.value) != 3) return -EINVAL; - *regoff = get_reg_offset(insn, regs, REG_TYPE_RM); + *regoff = get_reg_offset(insn, REG_TYPE_RM); if (*regoff < 0) return -EINVAL; @@ -1035,7 +1034,7 @@ static int get_eff_addr_modrm(struct insn *insn, struct pt_regs *regs, if (X86_MODRM_MOD(insn->modrm.value) > 2) return -EINVAL; - *regoff = get_reg_offset(insn, regs, REG_TYPE_RM); + *regoff = get_reg_offset(insn, REG_TYPE_RM); /* * -EDOM means that we must ignore the address_offset. In such a case, @@ -1181,8 +1180,8 @@ static int get_eff_addr_sib(struct insn *insn, struct pt_regs *regs, if (!insn->sib.nbytes) return -EINVAL; - *base_offset = get_reg_offset(insn, regs, REG_TYPE_BASE); - indx_offset = get_reg_offset(insn, regs, REG_TYPE_INDEX); + *base_offset = get_reg_offset(insn, REG_TYPE_BASE); + indx_offset = get_reg_offset(insn, REG_TYPE_INDEX); /* * Negative values in the base and index offset means an error when -- 2.51.1