From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33EB7322753 for ; Mon, 17 Nov 2025 09:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763371949; cv=none; b=Y4qwxprYguAiBtBhbKySZwZaWnEtPTgg8VHClQxIuh4T02XZrtZEwdS3o2lUE4jRJ1KNtNlVYl9tKvf5lHuTlmgzK+u7CWoupPjHRhuA/Aypru3ZJi5IAOtqjQ58aC1n4++jQWn7dgHPYjN7BW1QbvaMNu2ZgXNYlCh8X8FWkU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763371949; c=relaxed/simple; bh=gZZn1PcxXXFJfp9Qf0We8NQ8p6Wf5LeZgOIW7yWY7Ug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k3ALw+Q6LZxU46Db2Wv5U1/Z+l/aHmgBVzkxMFXNKvDXqbb69WxsOxsOE+mEHFWmTYckhHDY9seoMQgpbidnIZwRKJXWfC+oFeAzjL4FjB2/3zYfgFgRuHCzS5SKlRXLeTH4t3LbBDjq/nyLYkK+W1mlhnq2hyvmAaxkIadw8KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YiOZcW2L; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YiOZcW2L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B071C4CEFB; Mon, 17 Nov 2025 09:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763371948; bh=gZZn1PcxXXFJfp9Qf0We8NQ8p6Wf5LeZgOIW7yWY7Ug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YiOZcW2LYL+3azFbU2hhVoMKKkEh9/mTf/BJdtYUTcgT7GGH8hOrlVQxQT/eXx5TE v7LP9VeZFG9mo09BC7BGu3WtyFA6rdJEbdHA2rZn8fWaMynE+1ME48ezq10gZQadrD YIr5S3KdHqk3To0qHdRKqbRsu65/dm2C7ymyjiOCGfoCiEfRJK/WtM8Afb7DLJsZ12 b9weTT17u9na5lGJ6ybwL5FEmYE4NlZbAbJkXy1AzWlbcb/SF0mOaX4HU8558MdtZW gd7HdMI5Q0UT6D8FcaIPXI+kGT1zTUhsnpEyM339kFIx6jcLkpbkJY9B+AHmBbMN4h cXdSo1MPJy0Cg== From: Jiri Olsa To: Thomas Gleixner , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , Borislav Petkov , Dave Hansen Subject: [PATCH 4/5] x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off Date: Mon, 17 Nov 2025 10:31:36 +0100 Message-ID: <20251117093137.572132-5-jolsa@kernel.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org> References: <20251117093137.572132-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It's not used, insn_get_modrm_reg_off returns only offset to struct pt_regs, not the actual register values. Signed-off-by: Jiri Olsa --- arch/x86/include/asm/insn-eval.h | 2 +- arch/x86/lib/insn-eval.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/insn-eval.h b/arch/x86/include/asm/insn-eval.h index 500654d9eaeb..63866ac12a08 100644 --- a/arch/x86/include/asm/insn-eval.h +++ b/arch/x86/include/asm/insn-eval.h @@ -20,7 +20,7 @@ int pt_regs_offset(int regno); bool insn_has_rep_prefix(struct insn *insn); void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs); int insn_get_modrm_rm_off(struct insn *insn); -int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs); +int insn_get_modrm_reg_off(struct insn *insn); unsigned long *insn_get_modrm_reg_ptr(struct insn *insn, struct pt_regs *regs); unsigned long insn_get_seg_base(struct pt_regs *regs, int seg_reg_idx); int insn_get_code_seg_params(struct pt_regs *regs); diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 71f58d437253..56563a5c4b42 100644 --- a/arch/x86/lib/insn-eval.c +++ b/arch/x86/lib/insn-eval.c @@ -865,14 +865,13 @@ int insn_get_modrm_rm_off(struct insn *insn) /** * insn_get_modrm_reg_off() - Obtain register in reg part of the ModRM byte * @insn: Instruction containing the ModRM byte - * @regs: Register values as seen when entering kernel mode * * Returns: * * The register indicated by the reg part of the ModRM byte. The * register is obtained as an offset from the base of pt_regs. */ -int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs) +int insn_get_modrm_reg_off(struct insn *insn) { return get_reg_offset(insn, REG_TYPE_REG); } @@ -891,7 +890,7 @@ unsigned long *insn_get_modrm_reg_ptr(struct insn *insn, struct pt_regs *regs) { int offset; - offset = insn_get_modrm_reg_off(insn, regs); + offset = insn_get_modrm_reg_off(insn); if (offset < 0) return NULL; return (void *)regs + offset; -- 2.51.1