From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BCB32142E for ; Mon, 17 Nov 2025 09:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763371958; cv=none; b=NFEj+V8aMlM/3ojVRG31ecOYFFZENlrDDAjJFn8U1GNXxtPYgV2eo5P6fBj52nlDISFNmzNS3S3+COMHK2/2Yejda8+JOij5ZQY9yl+nP+LxN2Si5W4DUKLealNS2/xDIurDzhISxcnBDmN1Ndvgglvbz8KyJo32unsicOLrwz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763371958; c=relaxed/simple; bh=GftbMhppSZO4SFjsKvhpu8xTSLsH1FgZ4pMLv6THYu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QwtujTOMKvLkzyfYfJ4BiFIIdToFwoRvRi+45Ec4Zl39KXjaXv6+ewbMDhFo9AjKT5l40GCpSesWgz+rarYXumDTJ4H7JS1EiU4Y9GM2oVp8odSQ2Rpw/b8MatvpdU288TkQaS1XyynNaPIBGL2X7twMtsuEEfIvq0l0ReZztWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r2GDdsgE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r2GDdsgE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 557B8C4AF09; Mon, 17 Nov 2025 09:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763371958; bh=GftbMhppSZO4SFjsKvhpu8xTSLsH1FgZ4pMLv6THYu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r2GDdsgEsZv0cYhaZcBt59B2fhXk/mRmJVEqAhfPW0MvO9TIkUo/hW8IYsAl1SGfX qh/RnDzqHPnBa8KtErJsuErJ8mQJQmYS5xKDj9G/yC73mUwoMjpAV1w53pYIKw5jeO PQSDnjK4UPI1e5qspZbU5sUwXj5lvEASEMRHqZbKTXbckyp29o+cI2zt6Vp02Cx/Wc 9d6RBWi9rzljuxK4D0kgjvZKysgWebF7RB9cMOTJ4pDM30teuydzB+iojIwIpTAkGg Cw1gOQjqi6+Jvf6V8BmsuROn0rx8w7tFmuV24qgj6bG+bUP3KvkwImveIEvaKBhpZK LjsG5D420UcPw== From: Jiri Olsa To: Thomas Gleixner , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , Borislav Petkov , Dave Hansen Subject: [PATCH 5/5] x86/insn-eval: Remove regs arg from get_reg_offset_16 Date: Mon, 17 Nov 2025 10:31:37 +0100 Message-ID: <20251117093137.572132-6-jolsa@kernel.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org> References: <20251117093137.572132-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It's not used, get_reg_offset_16 returns only offset to struct pt_regs, not the actual register values. Signed-off-by: Jiri Olsa --- arch/x86/lib/insn-eval.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 56563a5c4b42..4d8878092330 100644 --- a/arch/x86/lib/insn-eval.c +++ b/arch/x86/lib/insn-eval.c @@ -532,7 +532,6 @@ static int get_reg_offset(struct insn *insn, enum reg_type type) /** * get_reg_offset_16() - Obtain offset of register indicated by instruction * @insn: Instruction containing ModRM byte - * @regs: Register values as seen when entering kernel mode * @offs1: Offset of the first operand register * @offs2: Offset of the second operand register, if applicable * @@ -546,8 +545,7 @@ static int get_reg_offset(struct insn *insn, enum reg_type type) * * 0 on success, -EINVAL on error. */ -static int get_reg_offset_16(struct insn *insn, struct pt_regs *regs, - int *offs1, int *offs2) +static int get_reg_offset_16(struct insn *insn, int *offs1, int *offs2) { /* * 16-bit addressing can use one or two registers. Specifics of @@ -1100,7 +1098,7 @@ static int get_eff_addr_modrm_16(struct insn *insn, struct pt_regs *regs, if (X86_MODRM_MOD(insn->modrm.value) > 2) return -EINVAL; - ret = get_reg_offset_16(insn, regs, &addr_offset1, &addr_offset2); + ret = get_reg_offset_16(insn, &addr_offset1, &addr_offset2); if (ret < 0) return -EINVAL; -- 2.51.1