From: Stephen Hemminger <stephen@networkplumber.org>
To: Yang Ming <mosesyyoung@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 2/2] net/mlx5: improve debug dump file path handling
Date: Mon, 17 Nov 2025 09:56:58 -0800 [thread overview]
Message-ID: <20251117095658.5e1a9580@phoenix> (raw)
In-Reply-To: <20250829144954.2576-2-mosesyyoung@gmail.com>
On Fri, 29 Aug 2025 22:49:53 +0800
Yang Ming <mosesyyoung@gmail.com> wrote:
> The current implementation always tries to open debug dump files
> under /var/log, which may not be writable in containerized or
> restricted environments (e.g. when the filesystem is mounted as
> read-only).
>
> This patch introduces an OS-specific helper function
> mlx5_os_debug_dump_file_open() to unify the logic:
>
> * On Linux:
> 1. Try /var/log if it is writable (kept for backward
> compatibility).
> 2. Fallback to the DPDK runtime directory.
> 3. Finally, use the current working directory.
>
> * On Windows:
> 1. Use the DPDK runtime directory.
> 2. Fallback to the current working directory.
>
> This preserves the previous directory preference while ensuring
> debug dumps can still be written in restricted environments such
> as containers. The structure of the open logic is kept unchanged
> so that test cases and expected logs remain valid.
>
> Signed-off-by: Yang Ming <mosesyyoung@gmail.com>
Mlx5 should follow current file system hierarchy standards.
Look at systemd documentation for information.
For example: /tmp should not be used for unix domain sockets
in a system service.
next prev parent reply other threads:[~2025-11-17 17:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:24 [PATCH 1/2] net/mlx5: improve socket file path Yang Ming
2024-12-13 9:24 ` [PATCH 2/2] net/mlx5: improve log " Yang Ming
2025-03-04 6:23 ` Bing Zhao
2025-03-05 3:20 ` Yang Ming
2025-03-10 14:59 ` Stephen Hemminger
2025-03-12 2:32 ` [External] " Yang Ming
2025-03-17 16:05 ` Bing Zhao
2025-03-21 9:48 ` Ming 1. Yang (NSB)
2024-12-13 17:12 ` [PATCH 1/2] net/mlx5: improve socket " Stephen Hemminger
2024-12-13 17:16 ` Bruce Richardson
2025-01-03 2:51 ` Yang Ming
2025-03-12 2:55 ` Yang Ming
2025-03-14 11:48 ` Dariusz Sosnowski
2025-03-21 13:27 ` [PATCH v2 1/2] net/mlx5: enhance " Yang Ming
2025-03-21 13:27 ` [PATCH v2 2/2] net/mlx5: enhance log " Yang Ming
2025-04-10 7:53 ` Yang Ming
2025-05-12 10:12 ` Moses Young
2025-06-04 6:54 ` Maayan Kashani
2025-06-26 13:06 ` Dariusz Sosnowski
2025-07-20 8:57 ` Moses Young
2025-06-26 12:48 ` [PATCH v2 1/2] net/mlx5: enhance socket " Dariusz Sosnowski
2025-08-29 14:49 ` [PATCH v3 1/2] net/mlx5: improve socket file path handling Yang Ming
2025-08-29 14:49 ` [PATCH v3 2/2] net/mlx5: improve debug dump " Yang Ming
2025-11-07 16:48 ` Dariusz Sosnowski
2025-11-17 17:56 ` Stephen Hemminger [this message]
2025-08-29 19:57 ` [PATCH v3 1/2] net/mlx5: improve socket " Stephen Hemminger
2025-08-31 0:55 ` Moses Young
2025-08-31 3:21 ` Stephen Hemminger
2025-09-01 1:40 ` Moses Young
2025-11-17 13:43 ` Raslan Darawsheh
2025-11-17 17:58 ` Stephen Hemminger
2025-11-18 14:45 ` Dariusz Sosnowski
2025-11-26 9:10 ` Moses Young
2025-11-08 1:16 ` [PATCH v2 1/2] net/mlx5: enhance socket file path Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117095658.5e1a9580@phoenix \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mosesyyoung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.