From: Stephen Hemminger <stephen@networkplumber.org>
To: Bing Zhao <bingz@nvidia.com>
Cc: <viacheslavo@nvidia.com>, <dev@dpdk.org>, <rasland@nvidia.com>,
<orika@nvidia.com>, <dsosnowski@nvidia.com>,
<suanmingm@nvidia.com>, <matan@nvidia.com>, <thomas@monjalon.net>,
<mkashani@nvidia.com>
Subject: Re: [PATCH 2/2] net/mlx5: fix the masked value for a rule for sync API
Date: Mon, 17 Nov 2025 09:59:46 -0800 [thread overview]
Message-ID: <20251117095946.0b9037b9@phoenix> (raw)
In-Reply-To: <20251117080942.9750-1-bingz@nvidia.com>
On Mon, 17 Nov 2025 10:09:42 +0200
Bing Zhao <bingz@nvidia.com> wrote:
> When inserting a rule via HWS synchronous API, the underlayer
> implementaiton is a bit different from HWS. The template(async)
> API calls are re-used. In the template API definition, the user
> should ensure that there is no value bit that is not masked by
> the template.
>
> In the legacy SWS synchronous API, when translating the item, if a
> mask is provided together with the spec. The value is the result of
> the spec OP-AND mask. If no mask, a default mask with all 1s are used
> and the value of the spec remain the original input.
>
> By introducing the new logic to do the OP-AND and duplicate the
> items from the input in the rte_flow layer. The spec field will
> be with the correct value after inline OP-AND calculating. The rule
> will be inserted with proper value as expected by the user.
>
> Fixes: e38776c36c8a ("net/mlx5: introduce HWS for non-template flow API")
> Cc: mkashani@nvidia.com
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> ---
> Depends-on: patch-158854("lib/ethdev: support inline calculating masked item value")
Please don't use depends-on if possible, since CI system doesn't really support it.
prev parent reply other threads:[~2025-11-17 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 8:09 [PATCH 2/2] net/mlx5: fix the masked value for a rule for sync API Bing Zhao
2025-11-17 17:59 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117095946.0b9037b9@phoenix \
--to=stephen@networkplumber.org \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.