From: Jakub Kicinski <kuba@kernel.org>
To: Parav Pandit <parav@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next] devlink: Notify eswitch mode changes to devlink monitor
Date: Mon, 17 Nov 2025 19:41:01 -0800 [thread overview]
Message-ID: <20251117194101.3b86a936@kernel.org> (raw)
In-Reply-To: <20251115025125.13485-1-parav@nvidia.com>
On Sat, 15 Nov 2025 04:51:25 +0200 Parav Pandit wrote:
> + err = devlink_nl_eswitch_fill(msg, devlink, DEVLINK_CMD_ESWITCH_SET,
I've never seen action command ID being used for a notification.
Either use an existing type which has the same message format,
or if no message which naturally fits exists allocate a new ID.
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-18 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 2:51 [PATCH net-next] devlink: Notify eswitch mode changes to devlink monitor Parav Pandit
2025-11-18 3:41 ` Jakub Kicinski [this message]
2025-11-18 5:25 ` Parav Pandit
2025-11-18 20:15 ` Jakub Kicinski
2025-11-19 13:49 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117194101.3b86a936@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.