Re: [PATCH net-next v14 4/5] eea: create/destroy rx,tx queues for netdevice open and stop

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 14 Nov 2025 14:15:05 +0800 Xuan Zhuo wrote:
> +static int eea_netdev_open(struct net_device *netdev)
> +{
> +	struct eea_net *enet = netdev_priv(netdev);
> +	struct eea_net_init_ctx ctx;
> +	int err;
> +
> +	if (enet->link_err) {
> +		netdev_err(netdev, "netdev open err, because link error: %d\n",
> +			   enet->link_err);
> +		return -EBUSY;
> +	}
> +
> +	enet_init_ctx(enet, &ctx);
> +
> +	err = eea_alloc_rxtx_q_mem(&ctx);
> +	if (err)
> +		return err;
> +
> +	enet_bind_new_q_and_cfg(enet, &ctx);
> +
> +	err = eea_active_ring_and_irq(enet);
> +	if (err)
> +		return err;
> +
> +	return eea_start_rxtx(netdev);

Looks like this is missing teardown in case eea_start_rxtx() failed
-- 
pw-bot: cr