From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
willemdebruijn.kernel@gmail.com, shuah@kernel.org,
sdf@fomichev.me, krakauer@google.com,
linux-kselftest@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 01/12] selftests: net: py: coding style improvements
Date: Mon, 17 Nov 2025 12:57:59 -0800 [thread overview]
Message-ID: <20251117205810.1617533-2-kuba@kernel.org> (raw)
In-Reply-To: <20251117205810.1617533-1-kuba@kernel.org>
We're about to add more features here and finding new issues with old
ones in place is hard. Address ruff checks:
- bare exceptions
- f-string with no params
- unused import
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
tools/testing/selftests/net/lib/py/ksft.py | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/net/lib/py/ksft.py b/tools/testing/selftests/net/lib/py/ksft.py
index 83b1574f7719..56dd9bd060cd 100644
--- a/tools/testing/selftests/net/lib/py/ksft.py
+++ b/tools/testing/selftests/net/lib/py/ksft.py
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-import builtins
import functools
import inspect
import signal
@@ -163,7 +162,7 @@ KSFT_DISRUPTIVE = True
entry = global_defer_queue.pop()
try:
entry.exec_only()
- except:
+ except Exception:
ksft_pr(f"Exception while handling defer / cleanup (callback {i} of {qlen_start})!")
tb = traceback.format_exc()
for line in tb.strip().split('\n'):
@@ -181,7 +180,7 @@ KSFT_DISRUPTIVE = True
@functools.wraps(func)
def wrapper(*args, **kwargs):
if not KSFT_DISRUPTIVE:
- raise KsftSkipEx(f"marked as disruptive")
+ raise KsftSkipEx("marked as disruptive")
return func(*args, **kwargs)
return wrapper
@@ -199,7 +198,7 @@ KSFT_DISRUPTIVE = True
return False
try:
return bool(int(value))
- except:
+ except Exception:
raise Exception(f"failed to parse {name}")
if "DISRUPTIVE" in env:
--
2.51.1
next prev parent reply other threads:[~2025-11-17 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 20:57 [PATCH net-next 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Jakub Kicinski
2025-11-17 20:57 ` Jakub Kicinski [this message]
2025-11-17 20:58 ` [PATCH net-next 02/12] selftests: net: py: extract the case generation logic Jakub Kicinski
2025-11-17 20:58 ` [PATCH net-next 03/12] selftests: net: py: add test variants Jakub Kicinski
2025-11-17 20:58 ` [PATCH net-next 04/12] selftests: drv-net: xdp: use variants for qstat tests Jakub Kicinski
2025-11-17 20:58 ` [PATCH net-next 05/12] selftests: net: relocate gro and toeplitz tests to drivers/net Jakub Kicinski
2025-11-18 2:07 ` Willem de Bruijn
2025-11-17 20:58 ` [PATCH net-next 06/12] selftests: net: py: support ksft ready without wait Jakub Kicinski
2025-11-17 20:58 ` [PATCH net-next 07/12] selftests: net: py: read ip link info about remote dev Jakub Kicinski
2025-11-17 20:58 ` [PATCH net-next 08/12] netdevsim: pass packets thru GRO on Rx Jakub Kicinski
2025-11-18 2:07 ` Willem de Bruijn
2025-11-17 20:58 ` [PATCH net-next 09/12] selftests: drv-net: add a Python version of the GRO test Jakub Kicinski
2025-11-18 2:08 ` Willem de Bruijn
2025-11-17 20:58 ` [PATCH net-next 10/12] selftests: drv-net: hw: convert the Toeplitz test to Python Jakub Kicinski
2025-11-18 2:09 ` Willem de Bruijn
2025-11-17 20:58 ` [PATCH net-next 11/12] netdevsim: add loopback support Jakub Kicinski
2025-11-17 20:58 ` [PATCH net-next 12/12] selftests: net: remove old setup_* scripts Jakub Kicinski
2025-11-18 2:11 ` [PATCH net-next 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Willem de Bruijn
2025-11-18 4:56 ` Jakub Kicinski
2025-11-18 14:13 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117205810.1617533-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krakauer@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.