All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk, hch@lst.de,
	ebiggers@kernel.org, Keith Busch <kbusch@kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] blk-integrity: support arbitrary buffer alignment
Date: Tue, 18 Nov 2025 07:45:13 +0100	[thread overview]
Message-ID: <20251118064513.GA24192@lst.de> (raw)
In-Reply-To: <20251117203935.1487303-1-kbusch@meta.com>

On Mon, Nov 17, 2025 at 12:39:35PM -0800, Keith Busch wrote:
>   * Fixed up ip checksum when it's split among intervals. The previous
>   version would happen to work if the data interval was aligned in a
>   single segment, but it would have gotten the wrong final result if it
>   had to do multiple partial updates.
> 
>   Testing this type was a little more difficult than it sounds. The
>   scsi_debug driver would force alignment, so it would never hit the
>   partial condition that was previously broken.
> 
>   To test it, I hacked up a nvme qemu emulation for this checksum type,
>   taking some liberty with the protocol's undefined fields.  qemu has
>   its own checksum implementation, 'net_raw_checksum()', and it is
>   calculating the same result through its contiguous bounce buffer as

Hah.  Even if it doesn't work for the IP checksum, can we wire up some
of your tests in blktests?

I think the new split_interval_capable need to be stacked as we still
build I/O to limits.  Not just for that it might be nice to turn it
into a BLK_FEAT_* bit.

Otherwise this looks good to me.

  reply	other threads:[~2025-11-18  6:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 20:39 [PATCH] blk-integrity: support arbitrary buffer alignment Keith Busch
2025-11-18  6:45 ` Christoph Hellwig [this message]
2025-11-18 21:26   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118064513.GA24192@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=ebiggers@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.