All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org
Cc: netdev@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next 2/4] net: increase default NAPI_SKB_CACHE_BULK to 32
Date: Tue, 18 Nov 2025 15:06:44 +0800	[thread overview]
Message-ID: <20251118070646.61344-3-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20251118070646.61344-1-kerneljasonxing@gmail.com>

From: Jason Xing <kernelxing@tencent.com>

The previous value 16 is a bit conservative, so adjust it along with
NAPI_SKB_CACHE_SIZE, which can minimize triggering memory allocation
in napi_skb_cache_get*().

Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
 net/core/skbuff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index e4abf0e56776..b6fe7ab85c4a 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -224,7 +224,7 @@ static void skb_under_panic(struct sk_buff *skb, unsigned int sz, void *addr)
 }
 
 #define NAPI_SKB_CACHE_SIZE	128
-#define NAPI_SKB_CACHE_BULK	16
+#define NAPI_SKB_CACHE_BULK	32
 #define NAPI_SKB_CACHE_HALF	(NAPI_SKB_CACHE_SIZE / 2)
 
 struct napi_alloc_cache {
-- 
2.41.3


  parent reply	other threads:[~2025-11-18  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18  7:06 [PATCH net-next 0/4] net: adjust conservative values around napi Jason Xing
2025-11-18  7:06 ` [PATCH net-next 1/4] net: increase default NAPI_SKB_CACHE_SIZE to 128 Jason Xing
2025-11-18  7:06 ` Jason Xing [this message]
2025-11-18  7:06 ` [PATCH net-next 3/4] net: use NAPI_SKB_CACHE_FREE to keep 32 as default to do bulk free Jason Xing
2025-11-18  7:06 ` [PATCH net-next 4/4] net: prefetch the next skb in napi_skb_cache_get() Jason Xing
2025-11-19  7:56 ` [PATCH net-next 0/4] net: adjust conservative values around napi Eric Dumazet
2025-11-19 17:51 ` Alexander Lobakin
2025-11-19 23:56   ` Jason Xing
2025-11-20  4:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118070646.61344-3-kerneljasonxing@gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernelxing@tencent.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.