From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69ED025F79A for ; Tue, 18 Nov 2025 08:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763455647; cv=none; b=lCzBN0snefi5fp6CsqYgWqwJGSnKr7n2k6Dw9iNkBDm989BB1Nd0IzHiZQJ9Ho5ZB+Xudt5tkrmNL+2cRUpB67YLyXe2DCtoiKiJ6nCJtwktX2cvdGm5szMZV/k4kf13L9jrb6Uomh2Ew5osuVfygw0FSoEZyFt0yRoCQFiY13U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763455647; c=relaxed/simple; bh=nWTDQmWAyCL70YIDwGDX7adGYnpdLNawi0Xd3SPc0+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PK+sQ25G9YB07OVH+lk2twuVpDc0eg2QH1GkflL+YD3OFMfddgOVVKQlkBhjkT3wyVCW+Q+3//NOztO9Fq8ef3NhZuqXQgql+Y8fGu0DKg3q+GtyP3gQVQfdatXTV2BlvnSiwgpfQoIo+GkIeTtEWJU+r8hw2u28h0QZPscHqxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=UDNpqKV9; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UDNpqKV9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RdnuOSinuoNEYAqLsZQcbpOdoMIxKbBxybRtwFSAmxk=; b=UDNpqKV9UaGxmm+0AENRRGXDup ToRc47a1ZHJsyQxvkgce3/asPc1Kj3yMISvfX9qDx0BA1kt6gvhsXIcOmJ1fJ5OU08KwB3PbUq3U3 IG+qhk/gP5lwEqN8Xobqa/8Aw0F2hP5iOlITpcmhwIvRYFv+LfP/0/FoyAabKp/gjfGHlQyby2wc8 5j+mvCLvBx3X3BIvO4R36vSJt5GiP7a0SuqtxsJC76Lm3oFJka+qG5mFapWyK9JN9eE1l/E0wM8KD xa+6Vm47clTz/CeISh6/ZXWopHa7a3nZ1uPA3NwLpr3vdX6fNCMaqXGQlhFa1O66mHogWwfxwWeku j8tn+bjg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLHMv-0000000FDGs-3aAv; Tue, 18 Nov 2025 08:47:21 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 62E86300325; Tue, 18 Nov 2025 09:47:21 +0100 (CET) Date: Tue, 18 Nov 2025 09:47:21 +0100 From: Peter Zijlstra To: Jiri Olsa Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions Message-ID: <20251118084721.GK3245006@noisy.programming.kicks-ass.net> References: <20251117093137.572132-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org> On Mon, Nov 17, 2025 at 10:31:32AM +0100, Jiri Olsa wrote: > hi, > regs argument is not used in several insn-eval functions, removing it. > > I have some changes based on these functions and it feels wrong to pass > NULL in regs argument. Also I don't want to send 5 extra patches with > my other change, so sending this separately. > > thanks, > jirka > > > --- > Jiri Olsa (5): > x86/insn-eval: Remove regs arg from pt_regs_offset > x86/insn-eval: Remove regs arg from get_reg_offset > x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off > x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off > x86/insn-eval: Remove regs arg from get_reg_offset_16 > > arch/x86/coco/sev/vc-handle.c | 2 +- > arch/x86/include/asm/insn-eval.h | 6 +++--- > arch/x86/kernel/cfi.c | 2 +- > arch/x86/kernel/umip.c | 2 +- > arch/x86/lib/insn-eval.c | 35 +++++++++++++++-------------------- > arch/x86/mm/extable.c | 2 +- > 6 files changed, 22 insertions(+), 27 deletions(-) Acked-by: Peter Zijlstra (Intel)