From: Francesco Dolcini <francesco@dolcini.it>
To: Ernest Van Hoecke <ernestvanhoecke@gmail.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2] configs: colibri-imx7*: set 'fdtfile' generically in PREBOOT
Date: Tue, 18 Nov 2025 16:35:13 +0100 [thread overview]
Message-ID: <20251118153513.GA56804@francesco-nb> (raw)
In-Reply-To: <20251118144815.1242023-1-ernestvanhoecke@gmail.com>
On Tue, Nov 18, 2025 at 03:48:00PM +0100, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>
> In TEZI (Toradex Easy Installer), we use one U-Boot binary for both our
> NAND and eMMC Colibri iMX7 modules. Currently, CONFIG_PREBOOT sets the
> environment variable 'fdtfile' depending on which defconfig was used,
> adding the '-emmc' variant for the emmc defconfig. Since we always build
> the TEZI recovery U-Boot with the standard (non-emmc) defconfig, fdtfile
> has to be overwritten later or it will be wrong there.
>
> By using '$variant', the fdtfile var is properly constructed at run time
> for both the NAND and eMMC variants, and we do not have to worry about
> setting fdtfile again when building the recovery TEZI U-Boot.
>
> This also synchronizes these configs with how we handle the iMX6ULL.
>
> Fixes: 327381e8b57c ("colibri_imx7: use preboot for fdtfile evaluation")
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
next prev parent reply other threads:[~2025-11-18 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 14:48 [PATCH v2] configs: colibri-imx7*: set 'fdtfile' generically in PREBOOT Ernest Van Hoecke
2025-11-18 15:35 ` Francesco Dolcini [this message]
2025-11-26 11:07 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118153513.GA56804@francesco-nb \
--to=francesco@dolcini.it \
--cc=emanuele.ghidoli@toradex.com \
--cc=ernest.vanhoecke@toradex.com \
--cc=ernestvanhoecke@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=jh80.chung@samsung.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=peng.fan@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.