All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: unexport ioctl_getflags
Date: Tue, 18 Nov 2025 07:59:13 -0800	[thread overview]
Message-ID: <20251118155913.GD196362@frogsfrogsfrogs> (raw)
In-Reply-To: <20251118070941.2368011-1-hch@lst.de>

On Tue, Nov 18, 2025 at 08:09:41AM +0100, Christoph Hellwig wrote:
> No modular users, nor should there be any for a dispatcher like this.

Does the same logic apply to the EXPORT_SYMBOLs of ioctl_setflags /
ioctl_fs[gs]etxattr?

--D

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/file_attr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/file_attr.c b/fs/file_attr.c
> index 1dcec88c0680..63d62742fbb1 100644
> --- a/fs/file_attr.c
> +++ b/fs/file_attr.c
> @@ -316,7 +316,6 @@ int ioctl_getflags(struct file *file, unsigned int __user *argp)
>  		err = put_user(fa.flags, argp);
>  	return err;
>  }
> -EXPORT_SYMBOL(ioctl_getflags);
>  
>  int ioctl_setflags(struct file *file, unsigned int __user *argp)
>  {
> -- 
> 2.47.3
> 
> 

  parent reply	other threads:[~2025-11-18 15:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18  7:09 [PATCH] fs: unexport ioctl_getflags Christoph Hellwig
2025-11-18 10:48 ` Johannes Thumshirn
2025-11-18 15:59 ` Darrick J. Wong [this message]
2025-11-19  5:43   ` Christoph Hellwig
2025-11-19  0:30 ` Al Viro
2025-11-19  5:43   ` Christoph Hellwig
2025-11-19  8:42 ` Christian Brauner
2025-11-19  9:01   ` Christoph Hellwig
2025-11-19  9:53     ` Christian Brauner
2025-11-19  8:45 ` Christian Brauner
2025-11-19  9:03   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118155913.GD196362@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=brauner@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.