Re: [PATCH v11 09/13] virtio-net: Add flow filter capability

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jun 04, 2024 at 04:28:59PM +0300, Parav Pandit wrote:
> +\begin{lstlisting}
> +struct virtio_net_ff_cap_data {
> +        le32 groups_limit;
> +        le32 selectors_limit;
> +        le32 rules_limit;
> +        le32 rules_per_group_limit;
> +        u8 last_rule_priority;
> +        u8 selectors_per_classifier_limit;
> +};
> +\end{lstlisting}


I don't know how I missed this, but this structure is not
aligned properly. In a typical compiler there's going
to be a 2 byte padding here :(


It's been a year ... do you think it's too late to fix?
Parav?
If it's been out too long then maybe we need a flag to fix it.

-- 
MST