All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: s-joshi@ti.com
Cc: meta-ti@lists.yoctoproject.org, kamlesh@ti.com,
	k-malarvizhi@ti.com, s-tripathi1@ti.com
Subject: Re: [meta-ti][scarthgap][PATCH v4] meta-ti-bsp: optee: Ensure libckteec.so symlink is installed
Date: Tue, 18 Nov 2025 14:01:18 -0500	[thread overview]
Message-ID: <20251118190118.GC3125@denix.org> (raw)
In-Reply-To: <20251117083407.3719468-1-s-joshi@ti.com>

On Mon, Nov 17, 2025 at 02:04:08PM +0530, Suhaas Joshi via lists.yoctoproject.org wrote:
> Presently, /usr/lib/libckteec.so is not installed. Instead, the only
> symlink present is /usr/lib/libckteec.so.0 which points to
> libckteec.so.0.1.0. This makes OpenSSL commands fail since it looks for
> /usr/bin/libckteec.so.
> 
> So ensure that this symlink is installed by explicitly adding a
> FILES:${PN} assignment.
> 
> Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
> ---
> v3 -> v4:
> * I realized that libckteec.so.0* and the PKCS#11 TA file were both already installed in the SDK.
>   Therefore, in v4, I have removed the logic for that since its redundant now. CFG_PKCS11_TA and
>   CFG_REE_FS are enabled by-default.
> * v4 only fixes one issue: the absence of libckteec.so. /usr/bin/libckteec.so should link to
>   /usr/bin/libckteec.so.0 which then links to /usr/bin/libckteec.so.0.1.0.

NAK

This patch seems to be unnecessary.

After 4 revisions it was determined that the necessary library is getting 
built and packaged.

I just checked and all the symlinks are also getting created. In accordance 
with Distro packaging guidelines, which OE follows, the *.so file is assumed 
to be a development symlink, hence it gets packaged into a corresponding *-dev 
package.

Simply pulling *.so symlink into the main package is not the right way to 
handle it. Doing so will trigger a QA error that will require a "dev-so" flag 
in INSANE_SKIP list - while not immediately violating YP Compat requirements, 
it's still not recommended.


> * Link to v3:
> https://lore.kernel.org/yocto-meta-ti/20251113104522.2443817-1-prc@list.ti.com/T/#t
> ---
>  .../recipes-security/optee/optee-client-ti-overrides.inc     | 1 +
>  meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend   | 5 +++++
>  2 files changed, 6 insertions(+)
>  create mode 100644 meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> 
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> new file mode 100644
> index 00000000..dd6a9d01
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> @@ -0,0 +1 @@
> +FILES:${PN} += "${libdir}/libckteec.so*"
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> index f193e78b..0cee127f 100644
> --- a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> +++ b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> @@ -2,3 +2,8 @@ OPTEE_TI_VERSION = ""
>  OPTEE_TI_VERSION:ti-soc = "${BPN}-ti-version.inc"
>  
>  require ${OPTEE_TI_VERSION}
> +
> +OPTEE_TI_OVERRIDES = ""
> +OPTEE_TI_OVERRIDES:ti-soc = "${BPN}-ti-overrides.inc"
> +
> +require ${OPTEE_TI_OVERRIDES}
> -- 
> 2.34.1


      parent reply	other threads:[~2025-11-18 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  8:34 [meta-ti][scarthgap][PATCH v4] meta-ti-bsp: optee: Ensure libckteec.so symlink is installed Suhaas Joshi
2025-11-17  8:40 ` PRC Automation
2025-11-17 19:06 ` Andrew Davis
2025-11-18  8:14   ` Suhaas Joshi
2025-11-18 16:29     ` Andrew Davis
2025-11-18 19:01 ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118190118.GC3125@denix.org \
    --to=denis@denix.org \
    --cc=k-malarvizhi@ti.com \
    --cc=kamlesh@ti.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=s-joshi@ti.com \
    --cc=s-tripathi1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.