From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Yishai Hadas" <yishaih@nvidia.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Alex Williamson" <alex@shazbot.org>,
virtualization@lists.linux.dev
Subject: Re: [PATCH] virtio_pci: drop kernel.h
Date: Wed, 19 Nov 2025 00:17:22 -0500 [thread overview]
Message-ID: <20251119001641-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <a1efb550481fc67973c0a86860e0724c8f5b9957.1763507303.git.mst@redhat.com>
On Tue, Nov 18, 2025 at 06:08:37PM -0500, Michael S. Tsirkin wrote:
> UAPI headers really have no business pulling in kernel.h
> Drop it - it does not seem to be needed, either.
>
> Fixes: 7c1ae151e812 ("virtio_pci: Introduce device parts access commands")
> Cc: "Yishai Hadas" <yishaih@nvidia.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Oops. Double checked and it's no good - I just had virtio disabled in
the config by mistake. Pls ignore.
> ---
> include/uapi/linux/virtio_pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index c691ac210ce2..d1b31efc4d7d 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -40,7 +40,6 @@
> #define _LINUX_VIRTIO_PCI_H
>
> #include <linux/types.h>
> -#include <linux/kernel.h>
>
> #ifndef VIRTIO_PCI_NO_LEGACY
>
> --
> MST
prev parent reply other threads:[~2025-11-19 5:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 23:08 [PATCH] virtio_pci: drop kernel.h Michael S. Tsirkin
2025-11-19 0:57 ` Chaitanya Kulkarni
2025-11-19 2:51 ` Jason Wang
2025-11-19 5:17 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119001641-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=alex@shazbot.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.