From: Christoph Hellwig <hch@lst.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>,
Alasdair Kergon <agk@redhat.com>, DMML <dm-devel@lists.linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dm-bufio: align write boundary on bdev_logical_block_size
Date: Wed, 19 Nov 2025 06:45:24 +0100 [thread overview]
Message-ID: <20251119054524.GA19993@lst.de> (raw)
In-Reply-To: <faafd90d-e41c-dcfc-cc25-7f29ff4f958c@redhat.com>
On Tue, Nov 18, 2025 at 06:45:55PM +0100, Mikulas Patocka wrote:
> I changed the patch below, so that it aligns write bios on
> max3(DM_BUFIO_WRITE_ALIGN, bdev_logical_block_size(b->c->bdev),
> bdev_physical_block_size(b->c->bdev)); - so that if physical block size is
> greater than logical block size, the writes are aligned so that the device
> doesn't do read-modify-write.
That doesn't make any sense whatsoever. The physical block size must
be >= logical block size, and the block enforces that.
next prev parent reply other threads:[~2025-11-19 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 12:33 [PATCH v2] dm-ebs: Mark full buffer dirty even on partial write Uladzislau Rezki (Sony)
2025-10-20 12:48 ` [PATCH] dm-bufio: align write boundary on bdev_logical_block_size Mikulas Patocka
2025-10-28 8:47 ` Uladzislau Rezki
2025-10-28 13:18 ` Uladzislau Rezki
2025-10-29 10:24 ` Mikulas Patocka
2025-10-29 13:06 ` Uladzislau Rezki
2025-11-10 10:26 ` Uladzislau Rezki
2025-11-18 4:00 ` Benjamin Marzinski
2025-11-18 11:15 ` Mikulas Patocka
2025-11-18 12:42 ` Uladzislau Rezki
2025-11-18 17:45 ` Mikulas Patocka
2025-11-18 20:36 ` Benjamin Marzinski
2025-11-19 5:45 ` Christoph Hellwig [this message]
2025-11-19 17:13 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119054524.GA19993@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.