All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Subject: Re: [PATCH] fs/ntfs3: check for shutdown in fsync
Date: Wed, 19 Nov 2025 12:07:46 +0800	[thread overview]
Message-ID: <202511191144.MLx5UTO4-lkp@intel.com> (raw)
In-Reply-To: <20251118130705.411336-1-almaz.alexandrovich@paragon-software.com>

Hi Konstantin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on linus/master v6.18-rc6 next-20251118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Konstantin-Komarov/fs-ntfs3-check-for-shutdown-in-fsync/20251118-210835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20251118130705.411336-1-almaz.alexandrovich%40paragon-software.com
patch subject: [PATCH] fs/ntfs3: check for shutdown in fsync
config: arm-randconfig-001-20251119 (https://download.01.org/0day-ci/archive/20251119/202511191144.MLx5UTO4-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511191144.MLx5UTO4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511191144.MLx5UTO4-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/ntfs3/file.c:1381:5: warning: no previous prototype for 'ntfs_file_fsync' [-Wmissing-prototypes]
    int ntfs_file_fsync(struct file *file, loff_t start, loff_t end, int datasync)
        ^~~~~~~~~~~~~~~
   fs/ntfs3/file.c:1415:12: warning: initialized field overwritten [-Woverride-init]
     .fsync  = ntfs_file_fsync,
               ^~~~~~~~~~~~~~~
   fs/ntfs3/file.c:1415:12: note: (near initialization for 'ntfs_file_operations.fsync')


vim +/ntfs_file_fsync +1381 fs/ntfs3/file.c

  1377	
  1378	/*
  1379	 * ntfs_file_fsync - file_operations::fsync
  1380	 */
> 1381	int ntfs_file_fsync(struct file *file, loff_t start, loff_t end, int datasync)
  1382	{
  1383		struct inode *inode = file_inode(file);
  1384		if (unlikely(ntfs3_forced_shutdown(inode->i_sb)))
  1385			return -EIO;
  1386	
  1387		return generic_file_fsync(file, start, end, datasync);
  1388	}
  1389	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2025-11-19  4:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 13:07 [PATCH] fs/ntfs3: check for shutdown in fsync Konstantin Komarov
2025-11-19  2:51 ` kernel test robot
2025-11-19  9:10   ` [PATCH v2] " Konstantin Komarov
2025-11-19  4:07 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202511191144.MLx5UTO4-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.