From: Jakub Kicinski <kuba@kernel.org>
To: "Remy D. Farley" <one-d-wide@protonmail.com>
Cc: Donald Hunter <donald.hunter@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v4 2/2] doc/netlink: Expand nftables specification
Date: Wed, 19 Nov 2025 20:03:04 -0800 [thread overview]
Message-ID: <20251119200304.7a0a7905@kernel.org> (raw)
In-Reply-To: <2a8b6847cbb9c4c09a2ddd6663294b8238b044ad.1763574466.git.one-d-wide@protonmail.com>
On Wed, 19 Nov 2025 18:16:00 +0000 Remy D. Farley wrote:
> Getting out some changes I've accumulated while making nftables work
> with Rust netlink-bindings. Hopefully, this will be useful upstream.
In the future it's better to keep things in smaller patches.
Easier to review.
The docs have to be in ReST-compatible format I see:
Documentation/netlink/specs/nftables.yaml:66: WARNING: Field list ends without a blank line; unexpected unindent.
Documentation/netlink/specs/nftables.yaml:261: WARNING: Bullet list ends without a blank line; unexpected unindent.
Documentation/netlink/specs/nftables.yaml:261: WARNING: Field list ends without a blank line; unexpected unindent.
`make htmldocs` to repro
> + # Defined in include/linux/netfilter/nf_tables.h
Isn't this the main header for nf_tables?
If yes then no need to comment, should be the obvious place.
If no - can we use
header: linux/netfilter/nf_tables.h
?
Last but not least when you post v2 please CC folks from netfilter:
NETFILTER
M: Pablo Neira Ayuso <pablo@netfilter.org>
M: Jozsef Kadlecsik <kadlec@netfilter.org>
M: Florian Westphal <fw@strlen.de>
R: Phil Sutter <phil@nwl.cc>
L: netfilter-devel@vger.kernel.org
L: coreteam@netfilter.org
S: Maintained
prev parent reply other threads:[~2025-11-20 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 18:16 [PATCH v4 2/2] doc/netlink: Expand nftables specification Remy D. Farley
2025-11-20 4:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119200304.7a0a7905@kernel.org \
--to=kuba@kernel.org \
--cc=donald.hunter@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=one-d-wide@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.