From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v1 05/11] Bluetooth: btnxpuart: Add TLS host hello handshake implementation
Date: Thu, 20 Nov 2025 07:10:09 +0800 [thread overview]
Message-ID: <202511200650.6IddJ89j-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251118142025.1982263-6-neeraj.sanjaykale@nxp.com>
References: <20251118142025.1982263-6-neeraj.sanjaykale@nxp.com>
TO: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
TO: marcel@holtmann.org
TO: luiz.dentz@gmail.com
CC: linux-bluetooth@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: amitkumar.karwar@nxp.com
CC: sherry.sun@nxp.com
CC: dmitrii.lebed@nxp.com
CC: neeraj.sanjaykale@nxp.com
Hi Neeraj,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.18-rc6 next-20251119]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Neeraj-Sanjay-Kale/Bluetooth-btnxpuart-Add-firmware-metadata-parsing-for-secure-interface/20251118-223605
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/20251118142025.1982263-6-neeraj.sanjaykale%40nxp.com
patch subject: [PATCH v1 05/11] Bluetooth: btnxpuart: Add TLS host hello handshake implementation
:::::: branch date: 33 hours ago
:::::: commit date: 33 hours ago
config: x86_64-randconfig-103-20251119 (https://download.01.org/0day-ci/archive/20251120/202511200650.6IddJ89j-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202511200650.6IddJ89j-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/bluetooth/btnxpuart.c:1781:12-13: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 1780)
vim +1781 drivers/bluetooth/btnxpuart.c
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1708
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1709 static struct sk_buff *nxp_host_do_hello(struct hci_dev *hdev)
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1710 {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1711 struct btnxpuart_dev *nxpdev = hci_get_drvdata(hdev);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1712 union nxp_tls_host_hello_payload tls_hello;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1713 struct nxp_tls_host_hello *host_hello = &tls_hello.host_hello;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1714 struct ecdh p = {0};
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1715 u8 *buf = NULL;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1716 unsigned int buf_len;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1717 struct sk_buff *skb;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1718 int ret;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1719
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1720 nxp_tls_hdr_init(&host_hello->hdr, sizeof(*host_hello), NXP_TLS_HOST_HELLO);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1721
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1722 host_hello->sig_alg = cpu_to_le16(NXP_TLS_ECDSA_SECP256R1_SHA256);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1723 host_hello->key_exchange_type = cpu_to_le16(NXP_TLS_ECDHE_SECP256R1);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1724 host_hello->cipher_suite = cpu_to_le16(NXP_TLS_AES_128_GCM_SHA256);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1725
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1726 get_random_bytes(host_hello->random, sizeof(host_hello->random));
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1727
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1728 /* Generate random private key */
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1729 p.key_size = 32;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1730 p.key = kzalloc(p.key_size, GFP_KERNEL);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1731 if (!p.key)
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1732 return ERR_PTR(-ENOMEM);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1733
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1734 get_random_bytes(p.key, p.key_size);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1735
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1736 buf_len = crypto_ecdh_key_len(&p);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1737 buf = kzalloc(buf_len, GFP_KERNEL);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1738 if (!buf) {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1739 ret = -ENOMEM;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1740 goto free_key;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1741 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1742
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1743 ret = crypto_ecdh_encode_key(buf, buf_len, &p);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1744 if (ret) {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1745 bt_dev_err(hdev, "crypto_ecdh_encode_key() failed");
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1746 goto free_buf;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1747 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1748
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1749 ret = crypto_kpp_set_secret(nxpdev->crypto.kpp, buf, buf_len);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1750 if (ret) {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1751 bt_dev_err(hdev, "crypto_kpp_set_secret() failed");
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1752 goto free_buf;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1753 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1754
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1755 ret = nxp_generate_ecdh_public_key(nxpdev->crypto.kpp, host_hello->pubkey);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1756 if (ret) {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1757 bt_dev_err(hdev, "Failed to generate ECDH public key: %d", ret);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1758 goto free_buf;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1759 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1760
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1761 ret = crypto_shash_update(nxpdev->crypto.tls_handshake_hash_desc,
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1762 (u8 *)host_hello, sizeof(*host_hello));
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1763 if (ret) {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1764 bt_dev_err(hdev, "Failed to update handshake hash: %d", ret);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1765 goto free_buf;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1766 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1767
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1768 tls_hello.msg_type = 0;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1769
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1770 skb = __hci_cmd_sync(hdev, HCI_NXP_SHI_ENCRYPT, sizeof(tls_hello),
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1771 tls_hello.buf, HCI_CMD_TIMEOUT);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1772 if (IS_ERR(skb)) {
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1773 bt_dev_err(hdev, "Host Hello command failed: %ld", PTR_ERR(skb));
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1774 ret = PTR_ERR(skb);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1775 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1776
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1777 free_buf:
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1778 kfree(buf);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1779 free_key:
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 @1780 memset(p.key, 0, p.key_size);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 @1781 kfree(p.key);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1782 if (ret)
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1783 return ERR_PTR(ret);
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1784 else
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1785 return skb;
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1786 }
9e92c12afdb6eb Neeraj Sanjay Kale 2025-11-18 1787
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-11-19 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 23:10 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-18 14:20 [PATCH v1 00/11] Bluetooth: btnxpuart: Add secure interface support for NXP chipsets Neeraj Sanjay Kale
2025-11-18 14:20 ` [PATCH v1 05/11] Bluetooth: btnxpuart: Add TLS host hello handshake implementation Neeraj Sanjay Kale
2025-11-22 3:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511200650.6IddJ89j-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.